Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: stop .split early at getFullPath #2474

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

perf: stop .split early at getFullPath #2474

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2799edd
perf: stop split early at getFullPath
gurgunday Jul 13, 2024
2332716
Merge branch 'master' into perf
gurgunday Jul 13, 2024
9b9aa83
Merge branch 'master' into perf
gurgunday Aug 2, 2024
0c7a8d6
Merge branch 'master' into perf
gurgunday Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
perf: stop split early at getFullPath
  • Loading branch information
@gurgunday
gurgunday committed Jul 13, 2024
commit 2799edd87f2a2065d216ec53ca3a8404f3c25173
2 changes: 1 addition & 1 deletion lib/compile/resolve.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ export function getFullPath(resolver: UriResolver, id = "", normalize?: boolean)

export function _getFullPath(resolver: UriResolver, p: URIComponent): string {
const serialized = resolver.serialize(p)
return serialized.split("#")[0] + "#"
return serialized.split("#", 1)[0] + "#"
}

const TRAILING_SLASH_HASH = /#\/?$/
Expand Down