Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

export ValidationError and MissingRefError #1840

Closed
wants to merge 5 commits into from
Closed

export ValidationError and MissingRefError #1840

wants to merge 5 commits into from

Conversation

Ginden
Copy link

@Ginden Ginden commented Dec 10, 2021

What issue does this pull request resolve?

#1832

What changes did you make?

Exported 2 Error subclasses.

Is there anything that requires more attention while reviewing?

@Ginden Ginden mentioned this pull request Dec 10, 2021
Open
@epoberezkin
Copy link
Member

Never saw this export format before :)

It should be added in other ajv classes too - core.ts, jtd.ts, 2019.ts and 2020.ts

@epoberezkin
Copy link
Member

Probably no need to export from core.ts.

epoberezkin
epoberezkin reviewed Jan 15, 2022
View reviewed changes
lib/ajv.ts Outdated Show resolved Hide resolved
@Ginden Ginden mentioned this pull request Mar 14, 2022
Closed
@dannyb648
Copy link
Contributor

What is required to get this over the line? Im hitting alot of issues trying to upgrade a codebase. Happy to get involved if possible

@epoberezkin
Copy link
Member

@dannyb648: It should be added in other ajv classes too - jtd.ts, 2019.ts and 2020.ts

@dannyb648 dannyb648 mentioned this pull request Jun 27, 2022
Merged
@dannyb648
Copy link
Contributor

@dannyb648: It should be added in other ajv classes too - jtd.ts, 2019.ts and 2020.ts

I've added these changes and the original ones to PR #2020 - Any chance of a review? Additionally looks like something is broken with the coverage plugin on all the PRs atm?

@MilkaChucky MilkaChucky mentioned this pull request Nov 19, 2022
Merged
kodiakhq bot referenced this pull request in X-oss-byte/Canary-nextjs Sep 26, 2023
@renovate
Update dependency ajv to v8.12.0 (#132)
2e70eef 
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [ajv](https://ajv.js.org) ([source](https://togithub.com/ajv-validator/ajv)) | [`8.11.0` -> `8.12.0`](https://renovatebot.com/diffs/npm/ajv/8.11.0/8.12.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/ajv/8.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/ajv/8.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/ajv/8.11.0/8.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/ajv/8.11.0/8.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>ajv-validator/ajv (ajv)</summary>

### [`v8.12.0`](https://togithub.com/ajv-validator/ajv/releases/tag/v8.12.0)

[Compare Source](https://togithub.com/ajv-validator/ajv/compare/v8.11.2...v8.12.0)

-   fix JTD serialisation (remove leading comma in objects with only optional properties) ([#&#8203;2190](https://togithub.com/ajv-validator/ajv/issues/2190), [@&#8203;piliugin-anton](https://togithub.com/piliugin-anton))
-   empty JTD "values" schema ([#&#8203;2191](https://togithub.com/ajv-validator/ajv/issues/2191))
-   empty object to work with JTD utility type ([#&#8203;2158](https://togithub.com/ajv-validator/ajv/issues/2158), [@&#8203;erikbrinkman](https://togithub.com/erikbrinkman))
-   fix JTD "discriminator" schema for objects with more than 8 properties ([#&#8203;2194](https://togithub.com/ajv-validator/ajv/issues/2194))
-   correctly narrow "number" type to "integer" ([#&#8203;2192](https://togithub.com/ajv-validator/ajv/issues/2192), [@&#8203;JacobLey](https://togithub.com/JacobLey))
-   update Node.js versions in CI to 14, 16, 18 and 19

### [`v8.11.2`](https://togithub.com/ajv-validator/ajv/releases/tag/v8.11.2)

[Compare Source](https://togithub.com/ajv-validator/ajv/compare/v8.11.1...v8.11.2)

Update dependencies

Export ValidationError and MissingRefError ([https://github.com/ajv-validator/ajv/pull/1840](https://togithub.com/ajv-validator/ajv/pull/1840), [@&#8203;dannyb648](https://togithub.com/dannyb648))

### [`v8.11.1`](https://togithub.com/ajv-validator/ajv/releases/tag/v8.11.1)

[Compare Source](https://togithub.com/ajv-validator/ajv/compare/v8.11.0...v8.11.1)

Update dependencies

Export ValidationError and MissingRefError ([#&#8203;1840](https://togithub.com/ajv-validator/ajv/issues/1840), [@&#8203;dannyb648](https://togithub.com/dannyb648))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/X-oss-byte/Canary-nextjs).
kodiakhq bot referenced this pull request in X-oss-byte/Nextjs Sep 30, 2023
@renovate
Update dependency ajv to v8.12.0 (#149)
2e001c8 
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [ajv](https://ajv.js.org) ([source](https://togithub.com/ajv-validator/ajv)) | [`8.11.0` -> `8.12.0`](https://renovatebot.com/diffs/npm/ajv/8.11.0/8.12.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/ajv/8.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/ajv/8.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/ajv/8.11.0/8.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/ajv/8.11.0/8.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>ajv-validator/ajv (ajv)</summary>

### [`v8.12.0`](https://togithub.com/ajv-validator/ajv/releases/tag/v8.12.0)

[Compare Source](https://togithub.com/ajv-validator/ajv/compare/v8.11.2...v8.12.0)

-   fix JTD serialisation (remove leading comma in objects with only optional properties) ([#&#8203;2190](https://togithub.com/ajv-validator/ajv/issues/2190), [@&#8203;piliugin-anton](https://togithub.com/piliugin-anton))
-   empty JTD "values" schema ([#&#8203;2191](https://togithub.com/ajv-validator/ajv/issues/2191))
-   empty object to work with JTD utility type ([#&#8203;2158](https://togithub.com/ajv-validator/ajv/issues/2158), [@&#8203;erikbrinkman](https://togithub.com/erikbrinkman))
-   fix JTD "discriminator" schema for objects with more than 8 properties ([#&#8203;2194](https://togithub.com/ajv-validator/ajv/issues/2194))
-   correctly narrow "number" type to "integer" ([#&#8203;2192](https://togithub.com/ajv-validator/ajv/issues/2192), [@&#8203;JacobLey](https://togithub.com/JacobLey))
-   update Node.js versions in CI to 14, 16, 18 and 19

### [`v8.11.2`](https://togithub.com/ajv-validator/ajv/releases/tag/v8.11.2)

[Compare Source](https://togithub.com/ajv-validator/ajv/compare/v8.11.1...v8.11.2)

Update dependencies

Export ValidationError and MissingRefError ([https://github.com/ajv-validator/ajv/pull/1840](https://togithub.com/ajv-validator/ajv/pull/1840), [@&#8203;dannyb648](https://togithub.com/dannyb648))

### [`v8.11.1`](https://togithub.com/ajv-validator/ajv/releases/tag/v8.11.1)

[Compare Source](https://togithub.com/ajv-validator/ajv/compare/v8.11.0...v8.11.1)

Update dependencies

Export ValidationError and MissingRefError ([#&#8203;1840](https://togithub.com/ajv-validator/ajv/issues/1840), [@&#8203;dannyb648](https://togithub.com/dannyb648))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/X-oss-byte/Nextjs).
This was referenced Jan 30, 2024
Closed
Merged
hkfb pushed a commit to equinor/webviz-subsurface-components that referenced this pull request Mar 12, 2024
@semantic-release-bot
chore(release): wsc-common@0.5.8 [skip ci]
2055f6e 
## [0.5.8](https://github.com/equinor/webviz-subsurface-components/compare/wsc-common@0.5.7...wsc-common@0.5.8) (2024-03-12)

### Bug Fixes

* bump ajv from 7.2.1 to 8.12.0 in /typescript ([#1947](#1947)) ([af95651](af95651)), closes [#2190](#2190) [#2191](#2191) [#2158](#2158) [#2194](#2194) [#2192](#2192) [ajv-validator/ajv#1840](ajv-validator/ajv#1840) [#1840](#1840) [#1901](#1901) [#1922](#1922) [#1862](#1862) [#1861](#1861) [#1815](#1815) [ajv-validator/ajv-keywords#220](ajv-validator/ajv-keywords#220) [#1819](#1819) [#1725](#1725) [#1757](#1757) [#2195](#2195) [#1971](#1971) [#2194](#2194) [#2184](#2184) [#2193](#2193) [#2183](#2183) [#2158](#2158) [#2160](#2160) [#1935](#1935) [#2192](#2192) [#1949](#1949) [#2191](#2191)
hkfb pushed a commit to equinor/webviz-subsurface-components that referenced this pull request Mar 12, 2024
@semantic-release-bot
chore(release): well-completions-plot@1.2.8 [skip ci]
da74de5 
## [1.2.8](https://github.com/equinor/webviz-subsurface-components/compare/well-completions-plot@1.2.7...well-completions-plot@1.2.8) (2024-03-12)

### Bug Fixes

* bump ajv from 7.2.1 to 8.12.0 in /typescript ([#1947](#1947)) ([af95651](af95651)), closes [#2190](#2190) [#2191](#2191) [#2158](#2158) [#2194](#2194) [#2192](#2192) [ajv-validator/ajv#1840](ajv-validator/ajv#1840) [#1840](#1840) [#1901](#1901) [#1922](#1922) [#1862](#1862) [#1861](#1861) [#1815](#1815) [ajv-validator/ajv-keywords#220](ajv-validator/ajv-keywords#220) [#1819](#1819) [#1725](#1725) [#1757](#1757) [#2195](#2195) [#1971](#1971) [#2194](#2194) [#2184](#2184) [#2193](#2193) [#2183](#2183) [#2158](#2158) [#2160](#2160) [#1935](#1935) [#2192](#2192) [#1949](#1949) [#2191](#2191)
hkfb pushed a commit to equinor/webviz-subsurface-components that referenced this pull request Mar 12, 2024
@semantic-release-bot
chore(release): subsurface-viewer@0.20.1 [skip ci]
c69afd1 
## [0.20.1](https://github.com/equinor/webviz-subsurface-components/compare/subsurface-viewer@0.20.0...subsurface-viewer@0.20.1) (2024-03-12)

### Bug Fixes

* bump ajv from 7.2.1 to 8.12.0 in /typescript ([#1947](#1947)) ([af95651](af95651)), closes [#2190](#2190) [#2191](#2191) [#2158](#2158) [#2194](#2194) [#2192](#2192) [ajv-validator/ajv#1840](ajv-validator/ajv#1840) [#1840](#1840) [#1901](#1901) [#1922](#1922) [#1862](#1862) [#1861](#1861) [#1815](#1815) [ajv-validator/ajv-keywords#220](ajv-validator/ajv-keywords#220) [#1819](#1819) [#1725](#1725) [#1757](#1757) [#2195](#2195) [#1971](#1971) [#2194](#2194) [#2184](#2184) [#2193](#2193) [#2183](#2183) [#2158](#2158) [#2160](#2160) [#1935](#1935) [#2192](#2192) [#1949](#1949) [#2191](#2191)
hkfb pushed a commit to equinor/webviz-subsurface-components that referenced this pull request Mar 12, 2024
@semantic-release-bot
chore(release): group-tree-plot@1.1.8 [skip ci]
edfacc2 
## [1.1.8](https://github.com/equinor/webviz-subsurface-components/compare/group-tree-plot@1.1.7...group-tree-plot@1.1.8) (2024-03-12)

### Bug Fixes

* bump ajv from 7.2.1 to 8.12.0 in /typescript ([#1947](#1947)) ([af95651](af95651)), closes [#2190](#2190) [#2191](#2191) [#2158](#2158) [#2194](#2194) [#2192](#2192) [ajv-validator/ajv#1840](ajv-validator/ajv#1840) [#1840](#1840) [#1901](#1901) [#1922](#1922) [#1862](#1862) [#1861](#1861) [#1815](#1815) [ajv-validator/ajv-keywords#220](ajv-validator/ajv-keywords#220) [#1819](#1819) [#1725](#1725) [#1757](#1757) [#2195](#2195) [#1971](#1971) [#2194](#2194) [#2184](#2184) [#2193](#2193) [#2183](#2183) [#2158](#2158) [#2160](#2160) [#1935](#1935) [#2192](#2192) [#1949](#1949) [#2191](#2191)
hkfb pushed a commit to equinor/webviz-subsurface-components that referenced this pull request Mar 12, 2024
@semantic-release-bot
chore(release): well-log-viewer@1.5.1 [skip ci]
13eb48c 
## [1.5.1](https://github.com/equinor/webviz-subsurface-components/compare/well-log-viewer@1.5.0...well-log-viewer@1.5.1) (2024-03-12)

### Bug Fixes

* bump ajv from 7.2.1 to 8.12.0 in /typescript ([#1947](#1947)) ([af95651](af95651)), closes [#2190](#2190) [#2191](#2191) [#2158](#2158) [#2194](#2194) [#2192](#2192) [ajv-validator/ajv#1840](ajv-validator/ajv#1840) [#1840](#1840) [#1901](#1901) [#1922](#1922) [#1862](#1862) [#1861](#1861) [#1815](#1815) [ajv-validator/ajv-keywords#220](ajv-validator/ajv-keywords#220) [#1819](#1819) [#1725](#1725) [#1757](#1757) [#2195](#2195) [#1971](#1971) [#2194](#2194) [#2184](#2184) [#2193](#2193) [#2183](#2183) [#2158](#2158) [#2160](#2160) [#1935](#1935) [#2192](#2192) [#1949](#1949) [#2191](#2191)
This was referenced May 22, 2024
Open
Open
@Mhmonicox Mhmonicox mentioned this pull request May 25, 2024
Open
@Z-byte-prog Z-byte-prog mentioned this pull request Jun 4, 2024
Closed
@Artur-data-DEV Artur-data-DEV mentioned this pull request Jun 5, 2024
Open
@NOUIY NOUIY mentioned this pull request Jun 17, 2024
Open
@matrix-compute matrix-compute mentioned this pull request Jun 24, 2024
Open
This was referenced Jun 25, 2024
Open
Open
@dulumina dulumina mentioned this pull request Jul 11, 2024
Open
@Mhmonicox Mhmonicox mentioned this pull request Jul 17, 2024
Open
@canarycr canarycr mentioned this pull request Jul 28, 2024
Open
@Stanislav1975 Stanislav1975 mentioned this pull request Aug 9, 2024
Open
@Mhmonicox Mhmonicox mentioned this pull request Aug 10, 2024
Open
@Z-byte-prog Z-byte-prog mentioned this pull request Aug 12, 2024
Closed
@snyk-io snyk-io bot mentioned this pull request Aug 12, 2024
Open
@ASISBusiness ASISBusiness mentioned this pull request Aug 16, 2024
Open
@Ramyromel Ramyromel mentioned this pull request Aug 28, 2024
Merged
@FlorentinTh FlorentinTh mentioned this pull request Sep 8, 2024
Open
@rish2497 rish2497 mentioned this pull request Sep 10, 2024
Open
@FlorentinTh FlorentinTh mentioned this pull request Sep 11, 2024
Open
@NOUIY NOUIY mentioned this pull request Sep 13, 2024
Open
@NOUIY NOUIY mentioned this pull request Sep 24, 2024
Open
@ReneMaetzschker ReneMaetzschker mentioned this pull request Oct 26, 2024
Open
@NOUIY NOUIY mentioned this pull request Oct 30, 2024
Open
@SkanderKasmi SkanderKasmi mentioned this pull request Nov 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epoberezkin epoberezkin epoberezkin left review comments

Assignees
No one assigned
Labels
needs changes
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ginden @epoberezkin @dannyb648