Update to latest fast-json-patch #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix the warning 'jsonpatch.apply is deprecated, please use `applyPatch` for applying patch sequences, or `applyOperation` to apply individual operations.' * Update to 2.0.6 version of fast-json-patch and address the deprecation warning * Update tests to include patch array of operations * Update docs with an example reason to use patch with a link to the json-patch spec
|
Also address #12 |
|
Will review :) |
epoberezkin
requested changes
Mar 11, 2018
keywords/patch.js
Outdated
|
|
||
| module.exports = function(ajv) { | ||
| addKeyword(ajv, '$patch', jsonPatch, { | ||
| addKeyword(ajv, '$patch', jsonPatch, 'applyPatch', { |
There was a problem hiding this comment.
you can pass jsonPatch.applyPatch here and jsonMergePatch.apply above. Then in add_keyword you would just need to use jsonPatch(null, source, patch, true); without any additional parameters.
| }, | ||
| "with": [ | ||
| { "op": "add", "path": "/properties/q", "value": { "type": "number" } } | ||
| { "op": "add", "path": "/properties/q", "value": { "type": "number" } }, | ||
| { "op": "add", "path": "/required/-", "value": "q" } |
There was a problem hiding this comment.
if you want to add "required" keyword and its change with "patch", then it has to be added with "merge" as well (it can replace the whole array) and also tested in "test_validate.js" (object without "q" should fail); as is it is not tested at all.
There was a problem hiding this comment.
thank you for the review. Changes submitted
* remove extra parameter from add_keyword; instead change the invoke targets to pass function * make the tests all require 'q' property; confirm it in test_validate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
applyPatchfor applying patch sequences, orapplyOperationto apply individual operations.'