forked from commons-app/apps-android-commons
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Feature/refactor contributions (commons-app#3046)
* * Refactored ContributionsListFragment to use RecyclerView * Added ContributionsPresenter * Extracted out the cursor to presenter * Probable fix for commons-app#3028 * Improved the logic for cache in ContributionViewHolder * Some more refactoring * While displaying images in ContributionsList, check if status is not completed && local uri exists, use that uri to show image * typo correction in LocalDataSource * Fixed formatting in ContributionsPresenter * retain adapter position when orientation changes * retain child position with its id * Made ContributionViewHolder not implement ViewHolder * Code formatting, review suggested changes * initialise the rv layout managers only when needed * added test cases for ContributionPresenter * removed not needed semi colon * added more java docs and code formatting
- Loading branch information
1 parent
108e28c
commit 60b1eb1
Showing
22 changed files
with
810 additions
and
588 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35 changes: 35 additions & 0 deletions
35
app/src/main/java/fr/free/nrw/commons/contributions/ContributionsContract.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
package fr.free.nrw.commons.contributions; | ||
|
||
import android.database.Cursor; | ||
import androidx.loader.app.LoaderManager; | ||
import fr.free.nrw.commons.BasePresenter; | ||
import fr.free.nrw.commons.Media; | ||
|
||
/** | ||
* The contract for Contributions View & Presenter | ||
*/ | ||
public class ContributionsContract { | ||
|
||
public interface View { | ||
|
||
void showWelcomeTip(boolean numberOfUploads); | ||
|
||
void showProgress(boolean shouldShow); | ||
|
||
void showNoContributionsUI(boolean shouldShow); | ||
|
||
void setUploadCount(int count); | ||
|
||
void onDataSetChanged(); | ||
} | ||
|
||
public interface UserActionListener extends BasePresenter<ContributionsContract.View>, | ||
LoaderManager.LoaderCallbacks<Cursor> { | ||
|
||
Contribution getContributionsFromCursor(Cursor cursor); | ||
|
||
void deleteUpload(Contribution contribution); | ||
|
||
Media getItemAtPosition(int i); | ||
} | ||
} |
Oops, something went wrong.