ROC curves for binary classification tasks (mljar#158)

ajschumacher · Apr 15, 2021 · 2ea3e37 · 2ea3e37
1 parent 0a9ee65
commit 2ea3e37
Showing 1 changed file with 15 additions and 12 deletions.
diff --git a/supervised/utils/additional_metrics.py b/supervised/utils/additional_metrics.py
@@ -325,15 +325,16 @@ def save_binary_classification(
             AdditionalMetrics.add_permutation_importance(
                 fout, model_path, fold_cnt, repeat_cnt
             )
-            AdditionalMetrics.add_shap_importance(
-                fout, model_path, fold_cnt, repeat_cnt
-            )
-            AdditionalMetrics.add_shap_binary(fout, model_path, fold_cnt, repeat_cnt)
 
             plots = additional_metrics.get("additional_plots")
             if plots is not None:
                 AdditionalPlots.append(fout, model_path, plots)
 
+            AdditionalMetrics.add_shap_importance(
+                fout, model_path, fold_cnt, repeat_cnt
+            )
+            AdditionalMetrics.add_shap_binary(fout, model_path, fold_cnt, repeat_cnt)
+
             fout.write("\n\n[<< Go back](../README.md)\n")
 
     @staticmethod
@@ -355,17 +356,18 @@ def save_multiclass_classification(
             AdditionalMetrics.add_permutation_importance(
                 fout, model_path, fold_cnt, repeat_cnt
             )
+
+            plots = additional_metrics.get("additional_plots")
+            if plots is not None:
+                AdditionalPlots.append(fout, model_path, plots)
+
             AdditionalMetrics.add_shap_importance(
                 fout, model_path, fold_cnt, repeat_cnt
             )
             AdditionalMetrics.add_shap_multiclass(
                 fout, model_path, fold_cnt, repeat_cnt
             )
 
-            plots = additional_metrics.get("additional_plots")
-            if plots is not None:
-                AdditionalPlots.append(fout, model_path, plots)
-
             fout.write("\n\n[<< Go back](../README.md)\n")
 
     @staticmethod
@@ -386,17 +388,18 @@ def save_regression(
             AdditionalMetrics.add_permutation_importance(
                 fout, model_path, fold_cnt, repeat_cnt
             )
+
+            plots = additional_metrics.get("additional_plots")
+            if plots is not None:
+                AdditionalPlots.append(fout, model_path, plots)
+
             AdditionalMetrics.add_shap_importance(
                 fout, model_path, fold_cnt, repeat_cnt
             )
             AdditionalMetrics.add_shap_regression(
                 fout, model_path, fold_cnt, repeat_cnt
             )
 
-            plots = additional_metrics.get("additional_plots")
-            if plots is not None:
-                AdditionalPlots.append(fout, model_path, plots)
-
             fout.write("\n\n[<< Go back](../README.md)\n")
 
     @staticmethod