forked from stanfordnlp/pyvene
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Activation collection to support probe training; iit training; relati…
…ve import path; more tutorials (stanfordnlp#24,stanfordnlp#26,stanfordnlp#40)
- Loading branch information
1 parent
76aceaa
commit 7af5600
Showing
33 changed files
with
2,279 additions
and
7,688 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
# Contributing Guidelines | ||
|
||
*Pull requests, bug reports, and all other forms of contribution are welcomed and highly encouraged!* :octocat: | ||
|
||
### :book: Pull Requests | ||
|
||
#### Uninstall pyvene from python library | ||
It becomes tricky if you have `pyvene` installed while debugging with this codebase, since imports can be easily messed up. Please run, | ||
```bash | ||
pip uninstall pyvene | ||
``` | ||
|
||
#### Unit Test Run Is A Must before Creating PRs | ||
When adding new methods or APIs, unit tests are now enforced. To run existing tests, you can kick off the python unittest command in the discovery mode as, | ||
```bash | ||
cd pyvene | ||
python -m unittest discover -p '*TestCase.py' | ||
``` | ||
When checking in new code, please also consider to add new tests in the same PR. Please include test results in the PR to make sure all the existing test cases are passing. Please see the `qa_runbook.ipynb` notebook about a set of conventions about how to add test cases. The code coverage for this repository is currently `low`, and we are adding more automated tests. | ||
|
||
#### Format | ||
``` | ||
**Descriptions**: | ||
[Describe your PR Here] | ||
**Testing Done**: | ||
[Provide logs, screen-shots, files that contain tests you have done] | ||
``` | ||
|
||
Go to issues, and open with a title formatted as, | ||
``` | ||
[Priority Tag] Short Title | ||
``` | ||
For Priority Tag, you can use P0-P2, P0 is the highest priority, which means everyone should stop working and focus on this PR. | ||
|
||
### :beetle: Bug Reports and Other Issues | ||
Go to issues, and open with a title formatted as, | ||
``` | ||
[Bug Fix] Short Title | ||
``` | ||
For external requests (i.e., you are not in our core dev team), please use, | ||
``` | ||
[External] Short Title | ||
``` | ||
|
||
### :inbox_tray: Larger Feature Requests | ||
Please email us! |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.