fix: calling setMode just before destroy causes error reading getLength #5727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5727 +/- ##
=======================================
Coverage 87.05% 87.06%
=======================================
Files 598 598
Lines 43703 43713 +10
Branches 7163 7164 +1
=======================================
+ Hits 38047 38057 +10
Misses 5656 5656
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
nightwing
reviewed
Jan 27, 2025
| var originalOnChangeMode = session.$onChangeMode; | ||
|
|
||
| // Create spy | ||
| session.$onChangeMode = function(...arguments) { |
Member
There was a problem hiding this comment.
Why do we need the spy here? we already could see the call by effects it produces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#5681
Description of changes:
When the editor is destroyed the pending callback(due to some async network request) created with editor.getSession.setMode causes an error which is avoided by aborting the callback in case if editor is destroyed.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Pull Request Checklist:
No backwards incompatible changes were made to Ace's public interface which is defined through the main typings file (ace.d.ts) and its references:
https://github.com/ajaxorg/ace/blob/master/ace.d.ts
https://github.com/ajaxorg/ace/blob/master/ace-modes.d.ts
https://github.com/ajaxorg/ace/blob/master/ace-extensions.d.ts