Skip to content

Conversation

@phil-hands
Copy link
Contributor

@phil-hands phil-hands commented Jan 23, 2025

Description of changes:

This replaces the two http URLs in package.json with https URLs.

This is to satisfy lintian (the pedantic package checker that we use in Debian)


FYI I just uploaded this as a package to Debian, in order to satisfy a dependency of openQA. See:

https://tracker.debian.org/pkg/node-ace-code

Hopefully that's OK with you -- I'm new to the world of Javascript packaging, so hopefully I've not done anything terrible to your code while packaging it, but if you happen to notice anything I'll be happy to improve the package.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Pull Request Checklist:

@codecov
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.05%. Comparing base (5acea6d) to head (5ae2079).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5721   +/-   ##
=======================================
  Coverage   87.05%   87.05%           
=======================================
  Files         598      598           
  Lines       43703    43703           
  Branches     7163     7163           
=======================================
  Hits        38047    38047           
  Misses       5656     5656           
Flag Coverage Δ
unittests 87.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nightwing nightwing merged commit 73f9f17 into ajaxorg:master Jan 27, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants