Skip to content

Conversation

@akoreman
Copy link
Contributor

@akoreman akoreman commented Dec 23, 2024

Issue #, if available: NA

Description of changes: we use String.match, which has a return type of RegExpMatchArray | null, this was not correctly picked up by our type generation. Explicitly set return type in this PR.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Pull Request Checklist:

@codecov
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.02%. Comparing base (713abb6) to head (b26c83f).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5705      +/-   ##
==========================================
- Coverage   87.02%   87.02%   -0.01%     
==========================================
  Files         598      598              
  Lines       43588    43593       +5     
  Branches     7162     7163       +1     
==========================================
+ Hits        37932    37936       +4     
- Misses       5656     5657       +1     
Flag Coverage Δ
unittests 87.02% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akoreman akoreman merged commit de21d50 into ajaxorg:master Dec 23, 2024
3 checks passed
@akoreman akoreman deleted the modelist_type_fix branch December 23, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants