Skip to content

Conversation

@akoreman
Copy link
Contributor

@akoreman akoreman commented Dec 20, 2024

Issue #, if available: NA

Description of changes: The current version number is part of the ace.d.ts and types/ace-modules.d.ts files, we need to update those as well when releasing a new version.

Fixes currently broken CI build on main branch.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Pull Request Checklist:

@github-actions
Copy link

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

@akoreman akoreman merged commit 9df7987 into ajaxorg:master Dec 20, 2024
2 checks passed
@akoreman akoreman deleted the bump_script_fix branch December 20, 2024 16:05
@codecov
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.02%. Comparing base (713abb6) to head (09f76cf).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5702   +/-   ##
=======================================
  Coverage   87.02%   87.02%           
=======================================
  Files         598      598           
  Lines       43588    43588           
  Branches     7162     7162           
=======================================
  Hits        37932    37932           
  Misses       5656     5656           
Flag Coverage Δ
unittests 87.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants