Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: recursive readdirSync for NodeJS < 20.1.0 #5645

Merged
merged 1 commit into from
Oct 20, 2024

Conversation

mkslanc
Copy link
Contributor

@mkslanc mkslanc commented Sep 20, 2024

Issue #, if available:

Description of changes:
Read all files with all subdirectories due to manual recursion

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Pull Request Checklist:

Copy link

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.97%. Comparing base (560f5d3) to head (4df1595).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5645   +/-   ##
=======================================
  Coverage   86.97%   86.97%           
=======================================
  Files         594      594           
  Lines       43395    43395           
  Branches     7170     7170           
=======================================
  Hits        37742    37742           
  Misses       5653     5653           
Flag Coverage Δ
unittests 86.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nightwing nightwing merged commit 2953f72 into ajaxorg:master Oct 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants