Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change curly braces insertion behavior for Markdown #4994

Merged
merged 1 commit into from
Nov 16, 2022

Conversation

mkslanc
Copy link
Contributor

@mkslanc mkslanc commented Nov 13, 2022

Issue #, if available: #4199

Description of changes:
Now curly braces insertion would act the same as [] and () for Markdown

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Nov 13, 2022

Codecov Report

Base: 86.08% // Head: 86.08% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (9716e60) compared to base (0c49167).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4994   +/-   ##
=======================================
  Coverage   86.08%   86.08%           
=======================================
  Files         544      546    +2     
  Lines       41511    41556   +45     
  Branches     6547     6551    +4     
=======================================
+ Hits        35735    35774   +39     
- Misses       5776     5782    +6     
Flag Coverage Δ
unittests 86.08% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/mode/markdown.js 67.85% <100.00%> (-2.15%) ⬇️
src/virtual_renderer.js 79.37% <0.00%> (-0.46%) ⬇️
src/lib/keys.js 100.00% <0.00%> (ø)
src/mode/jexl_highlight_rules.js 100.00% <0.00%> (ø)
src/mode/jexl.js 100.00% <0.00%> (ø)
src/lib/dom.js 83.59% <0.00%> (+0.08%) ⬆️
src/ace_test.js 98.86% <0.00%> (+0.16%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@andrewnester andrewnester merged commit 2760234 into ajaxorg:master Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants