editor: firefox compatible issue: autocomplete may corrupt the editor value

[yurenchen000]

Describe the bug

Reopen Closed Tab, ace editor value may be corrution.
// on ubuntu, firefox

after little dig
I realize it's corrupted by textarea autocomplete of browser firefox.

Expected Behavior

the editor value shoud keep as orig

Current Behavior

editor value is corruption

Reproduction Steps

1. open ace page use firefox,
   put custor at any line of ace editor
   for example: https://ace.c9.io/

2. close the page

3. restore the page, via ctrl+shift+t
   or tab context-menu Reopen Closed Tab

//screenshot of step 1

//screenshot of step 3 (the first line is here)

Possible Solution

a quick fix:

///=== fix: firefox textarea autocomplete issue 
editor_ta = editor.textInput.getElement()
editor_ta.setAttribute("autocomplete", "off");

Additional Information/Context

OS: ubuntu 22 (gnome 42)
Browser: fireforx 141

Ace Version / Browser / OS / Keyboard layout

ace 1.43.2

[yurenchen000]

I think this patch can FIXIT

https://github.com/ajaxorg/ace/compare/master...yurenchen000:ace:firefox_autocomplete_corruption?expand=1

diff --git a/src/keyboard/textinput.js b/src/keyboard/textinput.js
index 7de343a52..ccde43c09 100644
--- a/src/keyboard/textinput.js
+++ b/src/keyboard/textinput.js
@@ -33,6 +33,7 @@ class TextInput {
         this.text.className = "ace_text-input";
 
         this.text.setAttribute("wrap", "off");
+        this.text.setAttribute("autocomplete", "off");
         this.text.setAttribute("autocorrect", "off");
         this.text.setAttribute("autocapitalize", "off");
         this.text.setAttribute("spellcheck", "false");

[marinsokol5]

Can confirm it happens on Firefox, don't see the issue in Chrome and Safari.
I can also confirm it gets fixed by the proposed patch.
Seeing the other properties on textArea it makes sense to disable the autocomplete one too, consumers can bring their own completion support.

@nightwing do you agree with the patch?