Skip to content

Commit

Permalink
ACPI / hotplug / PCI: Simplify hotplug_event()
Browse files Browse the repository at this point in the history
A few lines of code can be cut from hotplug_event() by defining
and initializing the slot variable at the top of the function,
so do that.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Tested-by: Mika Westerberg <mika.westerberg@linux.intel.com>
  • Loading branch information
rafaeljw committed Feb 5, 2014
1 parent 661b406 commit b75cece
Showing 1 changed file with 6 additions and 13 deletions.
19 changes: 6 additions & 13 deletions drivers/pci/hotplug/acpiphp_glue.c
Original file line number Diff line number Diff line change
Expand Up @@ -817,6 +817,7 @@ static void hotplug_event(acpi_handle handle, u32 type, void *data)
{
struct acpiphp_context *context = data;
struct acpiphp_func *func = &context->func;
struct acpiphp_slot *slot = func->slot;
struct acpiphp_bridge *bridge;
char objname[64];
struct acpi_buffer buffer = { .length = sizeof(objname),
Expand All @@ -838,27 +839,19 @@ static void hotplug_event(acpi_handle handle, u32 type, void *data)
pr_debug("%s: Bus check notify on %s\n", __func__, objname);
pr_debug("%s: re-enumerating slots under %s\n",
__func__, objname);
if (bridge) {
if (bridge)
acpiphp_check_bridge(bridge);
} else {
struct acpiphp_slot *slot = func->slot;
else if (!(slot->flags & SLOT_IS_GOING_AWAY))
enable_slot(slot);

if (!(slot->flags & SLOT_IS_GOING_AWAY))
enable_slot(slot);
}
break;

case ACPI_NOTIFY_DEVICE_CHECK:
/* device check */
pr_debug("%s: Device check notify on %s\n", __func__, objname);
if (bridge) {
acpiphp_check_bridge(bridge);
} else {
struct acpiphp_slot *slot = func->slot;

if (slot->flags & SLOT_IS_GOING_AWAY)
break;

} else if (!(slot->flags & SLOT_IS_GOING_AWAY)) {
/*
* Check if anything has changed in the slot and rescan
* from the parent if that's the case.
Expand All @@ -871,7 +864,7 @@ static void hotplug_event(acpi_handle handle, u32 type, void *data)
case ACPI_NOTIFY_EJECT_REQUEST:
/* request device eject */
pr_debug("%s: Device eject notify on %s\n", __func__, objname);
acpiphp_disable_and_eject_slot(func->slot);
acpiphp_disable_and_eject_slot(slot);
break;
}

Expand Down

0 comments on commit b75cece

Please sign in to comment.