Skip to content

Commit

Permalink
platform/x86: Fix dell driver init order
Browse files Browse the repository at this point in the history
Update the initcall ordering to satisfy the following dependency
ordering:

1. DCDBAS, ACPI_WMI
2. DELL_SMBIOS, DELL_RBTN
3. DELL_LAPTOP, DELL_WMI

By assigning them to the following initcall levels:

subsys_initcall: DCDBAS, ACPI_WMI
module_init: DELL_SMBIOS, DELL_RBTN
late_initcall: DELL_LAPTOP, DELL_WMI

Cc: Dominik Brodowski <linux@dominikbrodowski.net>
Cc: Mario.Limonciello@dell.com
Signed-off-by: Darren Hart (VMware) <dvhart@infradead.org>
  • Loading branch information
dvhart committed Mar 14, 2018
1 parent 4716007 commit 7129707
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion drivers/firmware/dcdbas.c
Original file line number Diff line number Diff line change
Expand Up @@ -639,7 +639,7 @@ static void __exit dcdbas_exit(void)
platform_driver_unregister(&dcdbas_driver);
}

module_init(dcdbas_init);
subsys_initcall_sync(dcdbas_init);
module_exit(dcdbas_exit);

MODULE_DESCRIPTION(DRIVER_DESCRIPTION " (version " DRIVER_VERSION ")");
Expand Down
2 changes: 1 addition & 1 deletion drivers/platform/x86/dell-smbios-base.c
Original file line number Diff line number Diff line change
Expand Up @@ -637,7 +637,7 @@ static void __exit dell_smbios_exit(void)
mutex_unlock(&smbios_mutex);
}

subsys_initcall(dell_smbios_init);
module_init(dell_smbios_init);
module_exit(dell_smbios_exit);

MODULE_AUTHOR("Matthew Garrett <mjg@redhat.com>");
Expand Down
2 changes: 1 addition & 1 deletion drivers/platform/x86/dell-wmi.c
Original file line number Diff line number Diff line change
Expand Up @@ -714,7 +714,7 @@ static int __init dell_wmi_init(void)

return wmi_driver_register(&dell_wmi_driver);
}
module_init(dell_wmi_init);
late_initcall(dell_wmi_init);

static void __exit dell_wmi_exit(void)
{
Expand Down

0 comments on commit 7129707

Please sign in to comment.