Skip to content

Commit

Permalink
[PATCH] mm: remove find_trylock_page
Browse files Browse the repository at this point in the history
Remove find_trylock_page as per the removal schedule.

Signed-off-by: Nick Piggin <npiggin@suse.de>
[ Let's see if anybody screams ]
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Nick Piggin authored and Linus Torvalds committed Feb 9, 2007
1 parent f049274 commit 6204530
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 34 deletions.
12 changes: 0 additions & 12 deletions Documentation/feature-removal-schedule.txt
Original file line number Diff line number Diff line change
Expand Up @@ -186,18 +186,6 @@ Who: Greg Kroah-Hartman <gregkh@suse.de>

---------------------------

What: find_trylock_page
When: January 2007
Why: The interface no longer has any callers left in the kernel. It
is an odd interface (compared with other find_*_page functions), in
that it does not take a refcount to the page, only the page lock.
It should be replaced with find_get_page or find_lock_page if possible.
This feature removal can be reevaluated if users of the interface
cannot cleanly use something else.
Who: Nick Piggin <npiggin@suse.de>

---------------------------

What: Interrupt only SA_* flags
When: Januar 2007
Why: The interrupt related SA_* flags are replaced by IRQF_* to move them
Expand Down
2 changes: 0 additions & 2 deletions include/linux/pagemap.h
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,6 @@ extern struct page * find_get_page(struct address_space *mapping,
unsigned long index);
extern struct page * find_lock_page(struct address_space *mapping,
unsigned long index);
extern __deprecated_for_modules struct page * find_trylock_page(
struct address_space *mapping, unsigned long index);
extern struct page * find_or_create_page(struct address_space *mapping,
unsigned long index, gfp_t gfp_mask);
unsigned find_get_pages(struct address_space *mapping, pgoff_t start,
Expand Down
20 changes: 0 additions & 20 deletions mm/filemap.c
Original file line number Diff line number Diff line change
Expand Up @@ -605,26 +605,6 @@ struct page * find_get_page(struct address_space *mapping, unsigned long offset)
}
EXPORT_SYMBOL(find_get_page);

/**
* find_trylock_page - find and lock a page
* @mapping: the address_space to search
* @offset: the page index
*
* Same as find_get_page(), but trylock it instead of incrementing the count.
*/
struct page *find_trylock_page(struct address_space *mapping, unsigned long offset)
{
struct page *page;

read_lock_irq(&mapping->tree_lock);
page = radix_tree_lookup(&mapping->page_tree, offset);
if (page && TestSetPageLocked(page))
page = NULL;
read_unlock_irq(&mapping->tree_lock);
return page;
}
EXPORT_SYMBOL(find_trylock_page);

/**
* find_lock_page - locate, pin and lock a pagecache page
* @mapping: the address_space to search
Expand Down

0 comments on commit 6204530

Please sign in to comment.