Fix default props

aivy0011 · Feb 8, 2018 · 3799427 · 3799427
1 parent 4664620
commit 3799427
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 8 deletions.
diff --git a/src/components/TableComponent.vue b/src/components/TableComponent.vue
@@ -87,12 +87,12 @@
             cacheKey: { default: null },
             cacheLifetime: { default: 5 },
 
-            tableClass: { default: settings.tableClass },
-            theadClass: { default: settings.theadClass },
-            tbodyClass: { default: settings.tbodyClass },
-            filterInputClass: { default: settings.filterInputClass },
-            filterPlaceholder: { default: settings.filterPlaceholder },
-            filterNoResults: { default: settings.filterNoResults },
+            tableClass: { default: () => settings.tableClass },
+            theadClass: { default: () => settings.theadClass },
+            tbodyClass: { default: () => settings.tbodyClass },
+            filterInputClass: { default: () => settings.filterInputClass },
+            filterPlaceholder: { default: () => settings.filterPlaceholder },
+            filterNoResults: { default: () => settings.filterNoResults },
         },
 
         data: () => ({

diff --git a/tests/components/TableComponent.test.js b/tests/components/TableComponent.test.js
@@ -185,15 +185,19 @@ describe('TableComponent', () => {
 
         document.body.innerHTML = `
             <div id="app">
-                <table-component
-                    :data="[]">
+                <table-component :data="[]">
                     <table-column show="firstName" label="First name"></table-column>
                 </table-component>
             </div>
         `;
 
         await createVm();
 
+        // Revert for next tests (needs refactoring...)
+        TableComponent.settings({
+            filterNoResults: 'There are no matching rows',
+        });
+
         expect(document.body.innerHTML).toMatchSnapshot();
     });