-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MS-353] Deploy Moonshot to EKS #292
Conversation
rm -rf /var/lib/apt/lists/* | ||
|
||
# python dependencies | ||
RUN pip3 install --no-cache-dir --upgrade pip && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need to use venv?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm i consider as the requirements are all in the container and isolated, there is no need to actually isolate them. as for our own local machine, we will need to isolate requirements from different project.
i would actually defer to your opinion on whether need to venv or not but that is my reasoning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, looks good then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Tested. Working as expected. Screen recording at the above Jira Ticket. |
Description
Deploy Moonshot to EKS
Motivation and Context
This is to prepare moonshot to deploy to CStack or other ways that external parties want to deploy as an application in their own cluster.
This is an example of how they can deploy moonshot in their kubernates cluster.
Type of Change
How to Test
Deploy the kubernates scripts
Load the website url and test it out.
Checklist
Please check all the boxes that apply to this pull request using "x":
Screenshots (if applicable)
[If the changes involve visual modifications, include screenshots or GIFs that demonstrate the changes.]
Additional Notes
[Add any additional information or context that might be relevant to reviewers.]
Developer Certificate of Origin