Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MS-353] Deploy Moonshot to EKS #292

Merged
merged 3 commits into from
Aug 7, 2024
Merged

[MS-353] Deploy Moonshot to EKS #292

merged 3 commits into from
Aug 7, 2024

Conversation

imda-lionelteo
Copy link
Collaborator

@imda-lionelteo imda-lionelteo commented Aug 7, 2024

Description

Deploy Moonshot to EKS

Motivation and Context

This is to prepare moonshot to deploy to CStack or other ways that external parties want to deploy as an application in their own cluster.

This is an example of how they can deploy moonshot in their kubernates cluster.

Type of Change

  • feat: A new feature

How to Test

Deploy the kubernates scripts
Load the website url and test it out.

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have added or updated the necessary documentation (README, API docs, etc.).
  • I have added appropriate unit tests or functional tests for the changes made.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have added any necessary dependencies or packages to the project's build configuration.
  • I have performed a self-review of my own code.
  • I have read, understood and agree to the Developer Certificate of Origin below, which this project utilises.

Screenshots (if applicable)

[If the changes involve visual modifications, include screenshots or GIFs that demonstrate the changes.]

Additional Notes

[Add any additional information or context that might be relevant to reviewers.]

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
   have the right to submit it under the open source license
   indicated in the file; or

(b) The contribution is based upon previous work that, to the best
   of my knowledge, is covered under an appropriate open source
   license and I have the right under that license to submit that
   work with modifications, whether created in whole or in part
   by me, under the same open source license (unless I am
   permitted to submit under a different license), as indicated
   in the file; or

(c) The contribution was provided directly to me by some other
   person who certified (a), (b) or (c) and I have not modified
   it.

(d) I understand and agree that this project and the contribution
   are public and that a record of the contribution (including all
   personal information I submit with it, including my sign-off) is
   maintained indefinitely and may be redistributed consistent with
   this project or the open source license(s) involved.

@imda-lionelteo imda-lionelteo changed the title Ms 353 [MS-353] Deploy Moonshot to EKS Aug 7, 2024
@imda-lionelteo imda-lionelteo self-assigned this Aug 7, 2024
rm -rf /var/lib/apt/lists/*

# python dependencies
RUN pip3 install --no-cache-dir --upgrade pip && \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to use venv?

Copy link
Collaborator Author

@imda-lionelteo imda-lionelteo Aug 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm i consider as the requirements are all in the container and isolated, there is no need to actually isolate them. as for our own local machine, we will need to isolate requirements from different project.

i would actually defer to your opinion on whether need to venv or not but that is my reasoning

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, looks good then.

Copy link
Contributor

@imda-kwokwk imda-kwokwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@imda-lionelteo imda-lionelteo merged commit e896a4d into dev_main Aug 7, 2024
2 checks passed
@imda-lionelteo imda-lionelteo deleted the ms-353 branch August 8, 2024 12:47
@imda-benedictlee
Copy link
Contributor

@imda-benedictlee
Copy link
Contributor

Tested. Working as expected. Screen recording at the above Jira Ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants