Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MS-632] [API] Update connector retry mechanism with tenacity library. Remove allow_retries #122

Merged
merged 8 commits into from
Oct 29, 2024

Conversation

imda-lionelteo
Copy link
Collaborator

@imda-lionelteo imda-lionelteo commented Oct 8, 2024

Description

Update retrying mechanism and making user experience better

Motivation and Context

While doing the unit tests for the connector endpoints, there are some key, values that are redundant.
This ticket addresses the following to make user experience better:

  1. Remove allow_retries and num_of_retries in replacement for a key max_attempts.
    With max_attempts it automatically defines if retries is necessary or not.

  2. Replace the naive implementation of retrying with a library that can provide other forms of retries (retries with jitter and others). The library to be used will be tenacity.

  3. Moving model attribute which is part of the optional params to a necessary attribute, but the key may be optional.

Type of Change

  • feat: A new feature

How to Test

Run unit-test or run a cookbook/recipe run

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have added or updated the necessary documentation (README, API docs, etc.).
  • I have added appropriate unit tests or functional tests for the changes made.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have added any necessary dependencies or packages to the project's build configuration.
  • I have performed a self-review of my own code.
  • I have read, understood and agree to the Developer Certificate of Origin below, which this project utilises.

Screenshots (if applicable)

[If the changes involve visual modifications, include screenshots or GIFs that demonstrate the changes.]

Additional Notes

There is an accompanying ticket in moonshot-data

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
   have the right to submit it under the open source license
   indicated in the file; or

(b) The contribution is based upon previous work that, to the best
   of my knowledge, is covered under an appropriate open source
   license and I have the right under that license to submit that
   work with modifications, whether created in whole or in part
   by me, under the same open source license (unless I am
   permitted to submit under a different license), as indicated
   in the file; or

(c) The contribution was provided directly to me by some other
   person who certified (a), (b) or (c) and I have not modified
   it.

(d) I understand and agree that this project and the contribution
   are public and that a record of the contribution (including all
   personal information I submit with it, including my sign-off) is
   maintained indefinitely and may be redistributed consistent with
   this project or the open source license(s) involved.

@imda-lionelteo imda-lionelteo self-assigned this Oct 8, 2024
@imda-lionelteo imda-lionelteo marked this pull request as draft October 8, 2024 06:18
@imda-lionelteo imda-lionelteo changed the title [MS-632] Update connector retry mechanism with tenacity library. Remove allow_retries [MS-632] [API] Update connector retry mechanism with tenacity library. Remove allow_retries Oct 8, 2024
Copy link
Contributor

@imda-jacksonboey imda-jacksonboey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested ok

@imda-jacksonboey imda-jacksonboey merged commit 92b129f into dev_main Oct 29, 2024
3 of 8 checks passed
@imda-jacksonboey imda-jacksonboey deleted the ms-632 branch October 29, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants