support origin param in aiven_extras.pg_create_subscription #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kathia-barahona
force-pushed
the
kathiabarahona/create_suscription_with_origin
branch
4 times, most recently
from
0e5a61c
to
781a009
Compare
rdunklau
reviewed
Jun 13, 2024
| arg_subscription_name, arg_connection_string, arg_publication_name, arg_slot_name, arg_copy_data::TEXT); | ||
|
|
||
| -- PG16 and later: Include the origin parameter only if it's 'none', as its default is any | ||
| IF pg_version >= 160000 AND arg_origin = 'none' THEN |
There was a problem hiding this comment.
nit: it would be better to validate the argument, eg:
- raise an error if PG < 16 and anything other than 'any' is passed
- raise an error if arg_origin is not 'any' or 'none'
kathia-barahona
force-pushed
the
kathiabarahona/create_suscription_with_origin
branch
from
781a009
to
cdf7d4c
Compare
rdunklau
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PG16 started supporting
originparameter onCREATE SUBSCRIPTION. Such value can beany(default) ornone