Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avn service cli also support Valkey #520

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

TibsAtWork
Copy link
Contributor

Describe your changes

avn service cli also supports connecting to an Aiven for Valkey service.

It connects to Valkey or Redis using whichever of valkey-cli or redis-cli is available (validated by trying it out!), but I think it's more useful to reference valkey-cli (only) in the text (it does say "such as"), especially as that will make it simpler to remove mention of Aiven for Caching when that is retired.

Checklist

  • The first paragraph of the page is on one line.
  • The other lines have a line break at 90 characters.
  • I checked the output.
  • I applied the style guide.
  • My links start with /docs/.

Signed-off-by: Tony Ibbs (Tibs) <tony.ibbs@aiven.io>
@TibsAtWork TibsAtWork requested a review from a team as a code owner October 22, 2024 12:44
Copy link
Contributor

@staceysalamon-aiven staceysalamon-aiven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@TibsAtWork TibsAtWork merged commit 6424c14 into main Oct 22, 2024
4 checks passed
@TibsAtWork TibsAtWork deleted the tibs-avn-service-cli-supports-valkey branch October 22, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants