-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix codestyle test #26
Conversation
As a background to the creation of this pull requesut, an update of pycodestyle on 7/31 and Flack8 on 8/1 occurred, and the tests failed. The pycodestyle modification was a minor modification to add spaces, and the test was successful, but the Flake8 modification was a moderate or larger modification, as the class Please let me know if you have any comments on this modification. このpull requesutを作成した経緯としまして、 pycodestyleの改修は、スペースを入れる軽微な修正でテストが成功したのですが、 こちらの改修について何かご意見あればお聞かせ下さい。 |
Just my opinion, I didn't check any changes about ConfigFileFinder. In general terms, the rollback to reffer old libraries, is not good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with Okada san.
What is the problem?
aiaccel
seems not to depend on ConfigFileFinder
, right?
This problem is occurring with This error occurs when flake8==5.0.1. |
Thank you for sharing the link. The bug about flake8_5.0.1 will be fixed in future but currently it's better to use 4.0.1, isn't it? |
I see, thank you! |
Because an error occurs when using flake8 5.01, modified to continue to use 4.01, which has been working stably. I also tried flake8 5.00 and got the same error. (What is "Changes requested"?) |
I see. So, I think we don't have to change anything in this PR, but could you open an Issue to use the latest flake8 after the bug is fixed? |
In that case(don't change anything), until the flake8 error is fixed, the test will fail and other merge will not be possible, is this correct? |
No, this PR will be merged after you create the issue (as a reminder). |
I see, I was mistaken. I created the issues. |
Thank you! |
* Fix #19 (#20) * Fix #21 (#22) * fix README (#23) * fix codestyle test (#26) * fix for pycodestyle * add flake8==4.0.1 * Feature/update readme (#25) * update README * add bash Co-authored-by: Yoshiaki Bando <yoshipon@users.noreply.github.com> * Fix resumption test for DB Co-authored-by: Takashi OKADA <tk.okada.github@gmail.com> Co-authored-by: KanaiYuma-aist <105629713+KanaiYuma-aist@users.noreply.github.com> Co-authored-by: Yoshiaki Bando <yoshipon@users.noreply.github.com>
* Fix #19 (#20) * Fix #21 (#22) * fix README (#23) * fix codestyle test (#26) * fix for pycodestyle * add flake8==4.0.1 * Feature/update readme (#25) * update README * add bash Co-authored-by: Yoshiaki Bando <yoshipon@users.noreply.github.com> * Fix TPE resumtion test (#29) * Fix tpe resumption test * fix tpe resumption test * Fix tep resumption test * add retry (#38) * Add dynamic loading of optimizer (#34) * (WIP) Add dynamic loading of optimizer by importlib. * (WIP) Add dynamic loading of optimizer by importlib. * Add dynamic loading of optimizer by importlib * Add dynamic loading of optimizer by importlib * Fix test code * fix test * Fix resumtioin test * Add dynamic loading of optimizer * Fix dynamic loading of optimizer * Function names and comments were rolled back. * Changed the standard optimizer specification method * changed the specification method for importing the standard optimizer. * change deserialize (#40) Co-authored-by: aramoto99 <aramoto-masahiro@aist.go.jp> * Merge branch 'main' of github:aistairc/aiaccel into feature/database * Fix codestyle * (WIP) Change TPE resume * Fix resume test * Feature/fix resume tpe (#41) * fix resume tpe * fix resume tpe * add if len(running_trials) > 0 * fix about trial number * Fix TPE resumption Co-authored-by: Takashi OKADA <tk.okada.github@gmail.com> Co-authored-by: KanaiYuma-aist <105629713+KanaiYuma-aist@users.noreply.github.com> Co-authored-by: Yoshiaki Bando <yoshipon@users.noreply.github.com>
* Fix #19 (#20) * Fix #21 (#22) * fix README (#23) * fix codestyle test (#26) * fix for pycodestyle * add flake8==4.0.1 * Feature/update readme (#25) * update README * add bash Co-authored-by: Yoshiaki Bando <yoshipon@users.noreply.github.com> * Fix TPE resumtion test (#29) * Fix tpe resumption test * fix tpe resumption test * Fix tep resumption test * add retry (#38) * Add dynamic loading of optimizer (#34) * (WIP) Add dynamic loading of optimizer by importlib. * (WIP) Add dynamic loading of optimizer by importlib. * Add dynamic loading of optimizer by importlib * Add dynamic loading of optimizer by importlib * Fix test code * fix test * Fix resumtioin test * Add dynamic loading of optimizer * Fix dynamic loading of optimizer * Function names and comments were rolled back. * Changed the standard optimizer specification method * changed the specification method for importing the standard optimizer. * change deserialize (#40) Co-authored-by: aramoto99 <aramoto-masahiro@aist.go.jp> * Merge branch 'main' of github:aistairc/aiaccel into feature/database * Fix codestyle * (WIP) Change TPE resume * Fix resume test * Feature/fix resume tpe (#41) * fix resume tpe * fix resume tpe * add if len(running_trials) > 0 * fix about trial number * Fix TPE resumption Co-authored-by: Takashi OKADA <tk.okada.github@gmail.com> Co-authored-by: KanaiYuma-aist <105629713+KanaiYuma-aist@users.noreply.github.com> Co-authored-by: Yoshiaki Bando <yoshipon@users.noreply.github.com>
* Data management function by database is added. By adding the `--fs` option argument to the startup command, data management functions by the conventional file system can be used. Extensive refactoring was performed around the addition of this functionality. * Update setup.py * Delete tests/test_data/work/state/ as it is not used in develop/database. * Develop/database fix test (#18) * fix for tests * delete space * pInfoDict -> p_info * Merge main into debelop/database (#31) * Fix #19 (#20) * Fix #21 (#22) * fix README (#23) * fix codestyle test (#26) * fix for pycodestyle * add flake8==4.0.1 * Feature/update readme (#25) * update README * add bash Co-authored-by: Yoshiaki Bando <yoshipon@users.noreply.github.com> * Fix resumption test for DB Co-authored-by: Takashi OKADA <tk.okada.github@gmail.com> Co-authored-by: KanaiYuma-aist <105629713+KanaiYuma-aist@users.noreply.github.com> Co-authored-by: Yoshiaki Bando <yoshipon@users.noreply.github.com> * Feature/database (#36) * Fix #19 (#20) * Fix #21 (#22) * fix README (#23) * Fixed a problem in which Snapshot could not be saved during parallel execution. * Add function of delete any data in DB/FS. * Fix code style Co-authored-by: Takashi OKADA <tk.okada.github@gmail.com> Co-authored-by: KanaiYuma-aist <105629713+KanaiYuma-aist@users.noreply.github.com> * Request to merge cumulative changes . (#37) * Fix #19 (#20) * Fix #21 (#22) * fix README (#23) * The report generation function can now be called by command. * Fix data inconsistency when excute resume. (#39) * Fix resume * Fixed problem with sirialize not working in fs mode * Remove unused package imports * Fixed a problem that the resume function did not work in fs mode. * The name workspace/state is the name of the old specification, so it was changed to the appropriate name workspace/snapshot. * Delete unnecessary directories in Workspace. * Delete unnecessary directories in Workspace. * Delete unnecessary directories in Workspace. * Delete unnecessary directories in Workspace. Co-authored-by: Takashi OKADA <tk.okada.github@gmail.com> Co-authored-by: KanaiYuma-aist <105629713+KanaiYuma-aist@users.noreply.github.com> * Add dynamic loading of optimizer, And fix resumtion test. (#42) * Fix #19 (#20) * Fix #21 (#22) * fix README (#23) * fix codestyle test (#26) * fix for pycodestyle * add flake8==4.0.1 * Feature/update readme (#25) * update README * add bash Co-authored-by: Yoshiaki Bando <yoshipon@users.noreply.github.com> * Fix TPE resumtion test (#29) * Fix tpe resumption test * fix tpe resumption test * Fix tep resumption test * add retry (#38) * Add dynamic loading of optimizer (#34) * (WIP) Add dynamic loading of optimizer by importlib. * (WIP) Add dynamic loading of optimizer by importlib. * Add dynamic loading of optimizer by importlib * Add dynamic loading of optimizer by importlib * Fix test code * fix test * Fix resumtioin test * Add dynamic loading of optimizer * Fix dynamic loading of optimizer * Function names and comments were rolled back. * Changed the standard optimizer specification method * changed the specification method for importing the standard optimizer. * change deserialize (#40) Co-authored-by: aramoto99 <aramoto-masahiro@aist.go.jp> * Merge branch 'main' of github:aistairc/aiaccel into feature/database * Fix codestyle * (WIP) Change TPE resume * Fix resume test * Feature/fix resume tpe (#41) * fix resume tpe * fix resume tpe * add if len(running_trials) > 0 * fix about trial number * Fix TPE resumption Co-authored-by: Takashi OKADA <tk.okada.github@gmail.com> Co-authored-by: KanaiYuma-aist <105629713+KanaiYuma-aist@users.noreply.github.com> Co-authored-by: Yoshiaki Bando <yoshipon@users.noreply.github.com> * Fix conflicts with main branch (#43) * Fix #19 (#20) * Fix #21 (#22) * fix README (#23) * fix codestyle test (#26) * fix for pycodestyle * add flake8==4.0.1 * Feature/update readme (#25) * update README * add bash Co-authored-by: Yoshiaki Bando <yoshipon@users.noreply.github.com> * Fix TPE resumtion test (#29) * Fix tpe resumption test * fix tpe resumption test * Fix tep resumption test * add retry (#38) * Add dynamic loading of optimizer (#34) * (WIP) Add dynamic loading of optimizer by importlib. * (WIP) Add dynamic loading of optimizer by importlib. * Add dynamic loading of optimizer by importlib * Add dynamic loading of optimizer by importlib * Fix test code * fix test * Fix resumtioin test * Add dynamic loading of optimizer * Fix dynamic loading of optimizer * Function names and comments were rolled back. * Changed the standard optimizer specification method * changed the specification method for importing the standard optimizer. * change deserialize (#40) Co-authored-by: aramoto99 <aramoto-masahiro@aist.go.jp> * Merge branch 'main' of github:aistairc/aiaccel into feature/database * Fix codestyle * (WIP) Change TPE resume * Fix resume test * Feature/fix resume tpe (#41) * fix resume tpe * fix resume tpe * add if len(running_trials) > 0 * fix about trial number * Fix TPE resumption Co-authored-by: Takashi OKADA <tk.okada.github@gmail.com> Co-authored-by: KanaiYuma-aist <105629713+KanaiYuma-aist@users.noreply.github.com> Co-authored-by: Yoshiaki Bando <yoshipon@users.noreply.github.com> * Fix codestyle Co-authored-by: KanaiYuma-aist <105629713+KanaiYuma-aist@users.noreply.github.com> Co-authored-by: Takashi OKADA <tk.okada.github@gmail.com> Co-authored-by: Yoshiaki Bando <yoshipon@users.noreply.github.com>
* Data management function by database is added. By adding the `--fs` option argument to the startup command, data management functions by the conventional file system can be used. Extensive refactoring was performed around the addition of this functionality. * Update setup.py * Delete tests/test_data/work/state/ as it is not used in develop/database. * Develop/database fix test (#18) * fix for tests * delete space * pInfoDict -> p_info * Merge main into debelop/database (#31) * Fix #19 (#20) * Fix #21 (#22) * fix README (#23) * fix codestyle test (#26) * fix for pycodestyle * add flake8==4.0.1 * Feature/update readme (#25) * update README * add bash Co-authored-by: Yoshiaki Bando <yoshipon@users.noreply.github.com> * Fix resumption test for DB Co-authored-by: Takashi OKADA <tk.okada.github@gmail.com> Co-authored-by: KanaiYuma-aist <105629713+KanaiYuma-aist@users.noreply.github.com> Co-authored-by: Yoshiaki Bando <yoshipon@users.noreply.github.com> * Feature/database (#36) * Fix #19 (#20) * Fix #21 (#22) * fix README (#23) * Fixed a problem in which Snapshot could not be saved during parallel execution. * Add function of delete any data in DB/FS. * Fix code style Co-authored-by: Takashi OKADA <tk.okada.github@gmail.com> Co-authored-by: KanaiYuma-aist <105629713+KanaiYuma-aist@users.noreply.github.com> * Request to merge cumulative changes . (#37) * Fix #19 (#20) * Fix #21 (#22) * fix README (#23) * The report generation function can now be called by command. * Fix data inconsistency when excute resume. (#39) * Fix resume * Fixed problem with sirialize not working in fs mode * Remove unused package imports * Fixed a problem that the resume function did not work in fs mode. * The name workspace/state is the name of the old specification, so it was changed to the appropriate name workspace/snapshot. * Delete unnecessary directories in Workspace. * Delete unnecessary directories in Workspace. * Delete unnecessary directories in Workspace. * Delete unnecessary directories in Workspace. Co-authored-by: Takashi OKADA <tk.okada.github@gmail.com> Co-authored-by: KanaiYuma-aist <105629713+KanaiYuma-aist@users.noreply.github.com> * Add dynamic loading of optimizer, And fix resumtion test. (#42) * Fix #19 (#20) * Fix #21 (#22) * fix README (#23) * fix codestyle test (#26) * fix for pycodestyle * add flake8==4.0.1 * Feature/update readme (#25) * update README * add bash Co-authored-by: Yoshiaki Bando <yoshipon@users.noreply.github.com> * Fix TPE resumtion test (#29) * Fix tpe resumption test * fix tpe resumption test * Fix tep resumption test * add retry (#38) * Add dynamic loading of optimizer (#34) * (WIP) Add dynamic loading of optimizer by importlib. * (WIP) Add dynamic loading of optimizer by importlib. * Add dynamic loading of optimizer by importlib * Add dynamic loading of optimizer by importlib * Fix test code * fix test * Fix resumtioin test * Add dynamic loading of optimizer * Fix dynamic loading of optimizer * Function names and comments were rolled back. * Changed the standard optimizer specification method * changed the specification method for importing the standard optimizer. * change deserialize (#40) Co-authored-by: aramoto99 <aramoto-masahiro@aist.go.jp> * Merge branch 'main' of github:aistairc/aiaccel into feature/database * Fix codestyle * (WIP) Change TPE resume * Fix resume test * Feature/fix resume tpe (#41) * fix resume tpe * fix resume tpe * add if len(running_trials) > 0 * fix about trial number * Fix TPE resumption Co-authored-by: Takashi OKADA <tk.okada.github@gmail.com> Co-authored-by: KanaiYuma-aist <105629713+KanaiYuma-aist@users.noreply.github.com> Co-authored-by: Yoshiaki Bando <yoshipon@users.noreply.github.com> * Fix conflicts with main branch (#43) * Fix #19 (#20) * Fix #21 (#22) * fix README (#23) * fix codestyle test (#26) * fix for pycodestyle * add flake8==4.0.1 * Feature/update readme (#25) * update README * add bash Co-authored-by: Yoshiaki Bando <yoshipon@users.noreply.github.com> * Fix TPE resumtion test (#29) * Fix tpe resumption test * fix tpe resumption test * Fix tep resumption test * add retry (#38) * Add dynamic loading of optimizer (#34) * (WIP) Add dynamic loading of optimizer by importlib. * (WIP) Add dynamic loading of optimizer by importlib. * Add dynamic loading of optimizer by importlib * Add dynamic loading of optimizer by importlib * Fix test code * fix test * Fix resumtioin test * Add dynamic loading of optimizer * Fix dynamic loading of optimizer * Function names and comments were rolled back. * Changed the standard optimizer specification method * changed the specification method for importing the standard optimizer. * change deserialize (#40) Co-authored-by: aramoto99 <aramoto-masahiro@aist.go.jp> * Merge branch 'main' of github:aistairc/aiaccel into feature/database * Fix codestyle * (WIP) Change TPE resume * Fix resume test * Feature/fix resume tpe (#41) * fix resume tpe * fix resume tpe * add if len(running_trials) > 0 * fix about trial number * Fix TPE resumption Co-authored-by: Takashi OKADA <tk.okada.github@gmail.com> Co-authored-by: KanaiYuma-aist <105629713+KanaiYuma-aist@users.noreply.github.com> Co-authored-by: Yoshiaki Bando <yoshipon@users.noreply.github.com> * change serialize timing Co-authored-by: aramoto99 <aramoto-masahiro@aist.go.jp> Co-authored-by: aramoto99 <107896581+aramoto99@users.noreply.github.com> Co-authored-by: Takashi OKADA <tk.okada.github@gmail.com> Co-authored-by: Yoshiaki Bando <yoshipon@users.noreply.github.com>
Fix for
Pycodestyle Test
andFlack8 Test
Pycodestyle Test
Flack8 Test