Skip to content

Conversation

@kensoh
Copy link
Member

@kensoh kensoh commented Dec 17, 2019

This commit includes the various updates needed for v5.11. For review only now, and not commit to master, because we haven't prepared the packaged zips, so the links to download are invalid.

@kensoh
Copy link
Member Author

kensoh commented Dec 17, 2019

Fyi @siowyisheng on the various updates needed for v5.11. For review only now, and not commit to master, because we haven't prepared the packaged zips, so the links to download are invalid.

Let me know if you have questions - you can whatsapp me or we discuss when we meet.

@kensoh
Copy link
Member Author

kensoh commented Dec 17, 2019

@siowyisheng I've looked thru https://github.com/actions/labeler/blob/master/README.md - I don't think we'll add the PR auto-labeller to v5.11. It doesn't add value to the current PR workflow as 99% of PRs are internally raised. So even by defining new labels and the criteria for labels, it is only tagging to what we already know.

It might help in indexing and search in future, eg IDE, Orchestrator, Core, but for now the v5 architecture doesn't benefit from the added complexity. For eg, now this PR fails due to incomplete or not-yet-setup configuration of the auto-labeller -

Screenshot 2019-12-17 at 5 04 13 PM

For v6 transition release, if you see its value in future PR workflows, can add it in then.

@kensoh kensoh closed this Dec 17, 2019
@kensoh kensoh reopened this Dec 17, 2019
@kensoh kensoh merged commit 660fada into master Dec 19, 2019
@kensoh kensoh deleted the pre_v6_release branch December 19, 2019 09:54
@kensoh
Copy link
Member Author

kensoh commented Jan 26, 2020

@siowyisheng code looks good for v5.11! I didn't double-check docs since its being rewritten.

The type you spotted in tagui.sikuli/tagui.py was also fixed in v.511

# before - helper function to return Region from (x1,y1),(x2,y2)
# after - helper function to return Region from (x1,y1)-(x2,y2)

https://github.com/kelaberetiv/TagUI/pull/646/files?file-filters%5B%5D=.py#diff-a751a505d3590684fd52b957741f2cd3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant