Update specs public API #1799
Merged
Update specs public API #1799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KrySeyt
force-pushed
the
refactor_schemas_api
branch
from
fb46dd2
to
8416dbf
Compare
Lancetnik
reviewed
Sep 21, 2024
| @@ -188,15 +195,15 @@ def _parse_and_serve( | |||
|
|
|||
| else: | |||
| raise ValueError( | |||
| f"Unknown extension given - {app}; Please provide app in format [python_module:FastStream] or [asyncapi.yaml/.json] - path to your application or documentation" | |||
| f"Unknown extension given - {docs}; Please provide app in format [python_module:AsyncAPIProto] or [asyncapi.yaml/.json] - path to your application or documentation" | |||
| ) | |||
|
|
|||
| for schema in (SchemaV3, SchemaV2_6): | |||
There was a problem hiding this comment.
I think, we can use inheritance here like Docs.parse() isntead of iteration
|
|
||
|
|
||
| def get_app_schema(app: Application) -> Schema: | ||
| def get_app_schema( |
There was a problem hiding this comment.
Why it requires options instead of Schema object?
KrySeyt
force-pushed
the
refactor_schemas_api
branch
from
b4dd13b
to
7d39128
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and specify which issue is being addressed. Additionally, provide relevant motivation and context.
Fixes # (issue number)
Type of change
Please delete options that are not relevant.
Checklist
scripts/lint.shshows no errors)scripts/test-cov.shscripts/static-analysis.sh