Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added additional parameters to HandlerException #1659

Merged
merged 7 commits into from
Aug 9, 2024
Merged

Added additional parameters to HandlerException #1659

merged 7 commits into from
Aug 9, 2024

Conversation

ulbwa
Copy link
Contributor

@ulbwa ulbwa commented Aug 9, 2024

Description

The HandlerException class has been enhanced with additional parameters, which are now passed to the message.ack, message.nack, and message.reject methods within the WatcherContext. This update allows the use of raise NackMessage(delay=5) instead of return message.nack(delay=5).

Fixed the logic in WatcherContext, where if a user explicitly raises NackMessage with retry=False, the context now calls message.nack() instead of message.reject().

Type of change

Please delete options that are not relevant.

  • Documentation (typos, code examples, or any documentation updates)
  • Bug fix (a non-breaking change that resolves an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would disrupt existing functionality)
  • This change requires a documentation update

Checklist

  • My code adheres to the style guidelines of this project (scripts/lint.sh shows no errors)
  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • Both new and existing unit tests pass successfully on my local environment by running scripts/test-cov.sh
  • I have ensured that static analysis tests are passing by running scripts/static-analysis.sh
  • I have included code examples to illustrate the modifications

@Lancetnik Lancetnik added enhancement New feature or request Core Issues related to core FastStream functionality and affects to all brokers labels Aug 9, 2024
Lancetnik
Lancetnik previously approved these changes Aug 9, 2024
@Lancetnik Lancetnik added this pull request to the merge queue Aug 9, 2024
Merged via the queue into airtai:main with commit 7fda6bf Aug 9, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Issues related to core FastStream functionality and affects to all brokers enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants