Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: update deps #1503

Merged
merged 3 commits into from
Jun 6, 2024
Merged

Chore: update deps #1503

merged 3 commits into from
Jun 6, 2024

Conversation

kumaranvpl
Copy link
Contributor

Description

Please include a summary of the change and specify which issue is being addressed. Additionally, provide relevant motivation and context.

Fixes # (issue number)

Type of change

Please delete options that are not relevant.

  • Documentation (typos, code examples, or any documentation updates)
  • Bug fix (a non-breaking change that resolves an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would disrupt existing functionality)
  • This change requires a documentation update

Checklist

  • My code adheres to the style guidelines of this project (scripts/lint.sh shows no errors)
  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • Both new and existing unit tests pass successfully on my local environment by running scripts/test-cov.sh
  • I have ensured that static analysis tests are passing by running scripts/static-analysis.sh
  • I have included code examples to illustrate the modifications

@kumaranvpl kumaranvpl requested a review from Lancetnik June 6, 2024 04:35
@Lancetnik
Copy link
Member

We have some strange problem with dirty-equals at new typing_extensions version (I suppose)
@kumaranvpl, can u please take a look on it?

@kumaranvpl
Copy link
Contributor Author

We have some strange problem with dirty-equals at new typing_extensions version (I suppose) @kumaranvpl, can u please take a look on it?

@Lancetnik Yes, it is a problem with new minor release of typing_extensions.
I have limited the version for python 3.8 and it is working fine now - 8fda614

Anyway python 3.8 support is ending in 5 month roughly - https://endoflife.date/python. So this is pretty much a temporary solution.

@Lancetnik Lancetnik enabled auto-merge June 6, 2024 09:48
@Lancetnik Lancetnik added this pull request to the merge queue Jun 6, 2024
Merged via the queue into main with commit 4ebaa65 Jun 6, 2024
30 checks passed
@Lancetnik Lancetnik deleted the update-deps branch June 6, 2024 10:08
@kumaranvpl kumaranvpl linked an issue Jun 7, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chore: update dependencies and fix failing tests in python 3.8
2 participants