Skip to content

Commit

Permalink
Fixes the CI bug that allows PRs with failed tests to be merged. (#1807)
Browse files Browse the repository at this point in the history
  • Loading branch information
davorrunje authored Sep 23, 2024
1 parent 689f674 commit 88e3018
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion .github/workflows/pr_tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -481,7 +481,13 @@ jobs:

# https://github.com/marketplace/actions/alls-green#why
check: # This job does nothing and is only used for the branch protection
if: github.event.pull_request.draft == false
# from: https://github.com/re-actors/alls-green
# Important: For this to work properly, it is a must to have the job always
# run, otherwise GitHub will make it skipped when any of the dependencies
# fail. In some contexts, skipped is interpreted as success which may lead
# to undesired, unobvious and even dangerous (as in security breach
# "dangerous") side-effects.
if: always()

needs:
- pre-commit-check
Expand Down

0 comments on commit 88e3018

Please sign in to comment.