Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Swift 5 #154

Merged
13 commits merged into from
May 13, 2019
Merged

Update to Swift 5 #154

13 commits merged into from
May 13, 2019

Conversation

ghost
Copy link

@ghost ghost commented Apr 30, 2019

  • Performed automatic update
  • Fixed resulting warnings

More info regarding the data.withUnsafeBytes deprecation warning can be found here.

@ghost ghost self-requested a review April 30, 2019 13:11
@ghost ghost self-assigned this Apr 30, 2019
@Jose-ElRobot
Copy link

1 Message
📖 Any non-trivial changes to code should be reflected in the changelog. Please consider adding a note in the Unreleased section of the CHANGELOG.md.

Generated by 🚫 Danger

JOSESwift/Sources/CryptoImplementation/AES.swift Outdated Show resolved Hide resolved
JOSESwift/Sources/JWEHeader.swift Show resolved Hide resolved
Tests/JWEHeaderTests.swift Show resolved Hide resolved
@ghost ghost self-requested a review May 13, 2019 07:36
Co-Authored-By: nathan-mohemian <nathan.ender@mohemian.com>
@ghost
Copy link
Author

ghost commented May 13, 2019

🙏 for the feedback @nathan-mohemian!

It's ready for re-review.

@ghost ghost merged commit b366f7e into master May 13, 2019
@ghost ghost deleted the feature/AG-426-swift-5 branch May 13, 2019 08:39
@ghost ghost mentioned this pull request Jun 27, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants