Skip to content

feat: improve mascot border contrast on background #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
airscripts merged 1 commit into from
Apr 6, 2026
Merged

feat: improve mascot border contrast on background #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/components/mascot.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ function armStyle(side: ArmSide, isRaised: boolean): CSSProperties {
position: 'absolute',
transformOrigin: 'top center',
background: 'var(--color-surface)',
border: '2px solid var(--color-border)',
border: '2px solid var(--color-border-mascot)',
...(side === 'left' ? { left: 2 } : { right: 2 }),
transition: 'transform 0.2s cubic-bezier(0.34,1.56,0.64,1)',
transform: isRaised ? ARM_TRANSFORM_RAISED[side] : ARM_TRANSFORM_REST[side],
Expand Down Expand Up @@ -258,7 +258,7 @@ function bubbleBoxStyle(): CSSProperties {
color: 'var(--color-text)',
fontFamily: 'var(--font-mono)',
background: 'var(--color-surface)',
border: '1.5px solid var(--color-border)',
border: '1.5px solid var(--color-border-mascot)',
boxShadow: '0 4px 16px rgba(0,0,0,0.10)',
};
}
Expand All @@ -272,7 +272,7 @@ function bubbleArrowOuterStyle(): CSSProperties {
position: 'absolute',
borderLeft: '8px solid transparent',
borderRight: '8px solid transparent',
borderTop: '9px solid var(--color-border)',
borderTop: '9px solid var(--color-border-mascot)',
};
}

Expand Down Expand Up @@ -537,7 +537,7 @@ export function Mascot({ rarity, isIndex }: MascotProps) {
position: 'absolute',
imageRendering: 'pixelated',
background: 'var(--color-surface)',
border: '2px solid var(--color-border)',
border: '2px solid var(--color-border-mascot)',
}}
>
<div
Expand All @@ -549,7 +549,7 @@ export function Mascot({ rarity, isIndex }: MascotProps) {
borderRadius: 2,
position: 'absolute',
transform: 'translateX(-50%)',
background: 'var(--color-border)',
background: 'var(--color-border-mascot)',
}}
/>

Expand Down Expand Up @@ -582,7 +582,7 @@ export function Mascot({ rarity, isIndex }: MascotProps) {
height: 28,
borderRadius: 4,
position: 'absolute',
border: '2px solid var(--color-border)',
border: '2px solid var(--color-border-mascot)',
background: 'var(--color-surface-raised)',
}}
>
Expand Down Expand Up @@ -610,7 +610,7 @@ export function Mascot({ rarity, isIndex }: MascotProps) {
borderRadius: 2,
position: 'absolute',
background: 'var(--color-surface)',
border: '2px solid var(--color-border)',
border: '2px solid var(--color-border-mascot)',
}}
/>

Expand All @@ -623,7 +623,7 @@ export function Mascot({ rarity, isIndex }: MascotProps) {
borderRadius: 2,
position: 'absolute',
background: 'var(--color-surface)',
border: '2px solid var(--color-border)',
border: '2px solid var(--color-border-mascot)',
}}
/>
</div>
Expand Down
4 changes: 4 additions & 0 deletions src/styles/global.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
@theme {
--color-bg: #f8f8f5;
--color-border: #e2e0d8;
--color-border-mascot: #dcdad0;
--color-surface: #ffffff;
--color-surface-raised: #f1f0ec;

Expand Down Expand Up @@ -38,6 +39,7 @@
:root {
--color-bg: #0f0f0e;
--color-border: #2e2c28;
--color-border-mascot: #4c4a42;
--color-surface: #1a1917;
--color-surface-raised: #242320;

Expand Down Expand Up @@ -72,6 +74,7 @@
--color-surface: #ffffff;
--color-surface-raised: #f1f0ec;
--color-border: #e2e0d8;
--color-border-mascot: #dcdad0;
--color-text: #1a1917;
--color-text-muted: #6b6860;
--color-text-faint: #9c9a92;
Expand All @@ -95,6 +98,7 @@
[data-theme='dark'] {
--color-bg: #0f0f0e;
--color-border: #2e2c28;
--color-border-mascot: #4c4a42;
--color-surface: #1a1917;
--color-surface-raised: #242320;
--color-text: #f0efe8;
Expand Down