Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly target Java 8 #134

Merged
merged 1 commit into from
Aug 12, 2021
Merged

Properly target Java 8 #134

merged 1 commit into from
Aug 12, 2021

Conversation

martint
Copy link
Member

@martint martint commented Aug 10, 2021

Fixes #133

@martint martint force-pushed the java8 branch 14 times, most recently from c9813ef to 9e1a424 Compare August 11, 2021 00:24
@martint martint requested a review from electrum August 11, 2021 00:27
@martint martint requested a review from dain August 11, 2021 05:33
Java 9+ added an overload of various methods in ByteBuffer. When compiling with Java 11+ and targeting Java 8 bytecode
the resulting signatures are invalid for JDK 8, so accesses below result in NoSuchMethodError. Accessing the
methods through the interface class works around the problem.

Ideally, we'd use "javac --release 8", but that doesn't work because Unsafe is not available in the signature data
for that profile.
@martint martint merged commit 5e353d0 into airlift:master Aug 12, 2021
@codelipenghui
Copy link

Thanks @martint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version 0.19 can't work with heap buffer on JDK1.8
3 participants