Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destination Snowflake: edit schema name which contains the character - #9743

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
93d53ac
fix for jdk 17
Dec 15, 2021
ede8d38
Merge branch 'master' of github.com:airbytehq/airbyte
Dec 15, 2021
27be3fe
Merge branch 'master' of github.com:airbytehq/airbyte
Dec 15, 2021
ca75033
Merge branch 'master' of github.com:airbytehq/airbyte
Dec 16, 2021
72ab46f
Merge branch 'master' of github.com:airbytehq/airbyte
Dec 16, 2021
aec3384
Merge branch 'master' of github.com:airbytehq/airbyte
Dec 16, 2021
7efd5aa
Merge branch 'master' of github.com:airbytehq/airbyte
Dec 20, 2021
6a773f9
Merge branch 'master' of github.com:airbytehq/airbyte
Dec 21, 2021
fa18537
Merge branch 'master' of github.com:airbytehq/airbyte
Dec 21, 2021
b0ba37b
Merge branch 'master' of github.com:airbytehq/airbyte
Dec 22, 2021
fa31a0d
Merge branch 'master' of github.com:airbytehq/airbyte
Dec 23, 2021
67e0bd6
Merge branch 'master' of github.com:airbytehq/airbyte
Dec 24, 2021
ec0d1bd
Merge branch 'master' of github.com:airbytehq/airbyte
Dec 28, 2021
23598ec
Merge branch 'master' of github.com:airbytehq/airbyte
Dec 28, 2021
59d63e6
Merge branch 'master' of github.com:airbytehq/airbyte
Dec 30, 2021
e2cb62c
Merge branch 'master' of github.com:airbytehq/airbyte
Jan 10, 2022
632583a
Merge branch 'master' of github.com:airbytehq/airbyte
Jan 10, 2022
2bc76ce
Merge branch 'master' of github.com:airbytehq/airbyte
Jan 11, 2022
9baf2e1
Merge branch 'master' of github.com:airbytehq/airbyte
Jan 12, 2022
ed4f1ba
Merge branch 'master' of github.com:airbytehq/airbyte
Jan 13, 2022
64f823f
Merge branch 'master' of github.com:airbytehq/airbyte
Jan 13, 2022
6cea9ab
Merge branch 'master' of github.com:airbytehq/airbyte
Jan 14, 2022
a2cb023
Merge branch 'master' of github.com:airbytehq/airbyte
Jan 14, 2022
475a34c
Merge branch 'master' of github.com:airbytehq/airbyte
Jan 17, 2022
f75c1c1
Merge branch 'master' of github.com:airbytehq/airbyte
Jan 18, 2022
3078535
Merge branch 'master' of github.com:airbytehq/airbyte
Jan 19, 2022
cc4e646
Merge branch 'master' of github.com:airbytehq/airbyte
Jan 20, 2022
2b8d8c1
Merge branch 'master' of github.com:airbytehq/airbyte
Jan 21, 2022
726798d
added heartbeat interval to Apache Mina settings
Jan 21, 2022
bf7f48e
fixed checkstyle
Jan 24, 2022
9349a29
Merge branch 'master' of github.com:airbytehq/airbyte
Jan 24, 2022
5c149fb
Merge branch 'master' into vmaltsev/3489-dest-snowflake-replace-dashe…
Jan 24, 2022
c57a798
bump versions
Jan 24, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"destinationDefinitionId": "424892c4-daac-4491-b35d-c6688ba547ba",
"name": "Snowflake",
"dockerRepository": "airbyte/destination-snowflake",
"dockerImageTag": "0.4.3",
"dockerImageTag": "0.4.4",
"documentationUrl": "https://docs.airbyte.io/integrations/destinations/snowflake",
"icon": "snowflake.svg"
}
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@
- name: Snowflake
destinationDefinitionId: 424892c4-daac-4491-b35d-c6688ba547ba
dockerRepository: airbyte/destination-snowflake
dockerImageTag: 0.4.3
dockerImageTag: 0.4.4
documentationUrl: https://docs.airbyte.io/integrations/destinations/snowflake
icon: snowflake.svg
- name: MariaDB ColumnStore
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,5 @@ COPY build/distributions/${APPLICATION}*.tar ${APPLICATION}.tar

RUN tar xf ${APPLICATION}.tar --strip-components=1

LABEL io.airbyte.version=0.4.3
LABEL io.airbyte.version=0.4.4
LABEL io.airbyte.name=airbyte/destination-snowflake
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ private static Function<ConfiguredAirbyteStream, WriteConfig> toWriteConfig(
Preconditions.checkNotNull(stream.getDestinationSyncMode(), "Undefined destination sync mode");
final AirbyteStream abStream = stream.getStream();

final String outputSchema = getOutputSchema(abStream, namingResolver.getIdentifier(config.get("schema").asText()));
final String outputSchema = getOutputSchema(abStream, config.get("schema").asText(), namingResolver);

final String streamName = abStream.getName();
final String tableName = namingResolver.getRawTableName(streamName);
Expand All @@ -94,12 +94,10 @@ private static Function<ConfiguredAirbyteStream, WriteConfig> toWriteConfig(
};
}

private static String getOutputSchema(final AirbyteStream stream, final String defaultDestSchema) {
final String sourceSchema = stream.getNamespace();
if (sourceSchema != null) {
return sourceSchema;
}
return defaultDestSchema;
private static String getOutputSchema(final AirbyteStream stream, final String defaultDestSchema, NamingConventionTransformer namingResolver) {
return stream.getNamespace() != null
? namingResolver.getIdentifier(stream.getNamespace())
: namingResolver.getIdentifier(defaultDestSchema);
}

private static OnStartFunction onStartFunction(final JdbcDatabase database,
Expand Down
1 change: 1 addition & 0 deletions docs/integrations/destinations/snowflake.md
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,7 @@ Finally, you need to add read/write permissions to your bucket with that email.

| Version | Date | Pull Request | Subject |
|:--------|:-----------| :----- | :------ |
| 0.4.4 | 2022-01-24 | [#9743](https://github.com/airbytehq/airbyte/pull/9743) | Fixed bug with dashes in schema name |
| 0.4.3 | 2022-01-20 | [#9531](https://github.com/airbytehq/airbyte/pull/9531) | Start using new S3StreamCopier and expose the purgeStagingData option |
| 0.4.2 | 2022-01-10 | [#9141](https://github.com/airbytehq/airbyte/pull/9141) | Fixed duplicate rows on retries |
| 0.4.1 | 2021-01-06 | [#9311](https://github.com/airbytehq/airbyte/pull/9311) | Update сreating schema during check |
Expand Down