Change severity of StateDeltaTrackerException from error to warning #9657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
subodh1810
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
When the MessageTracker sees a state hash that it has already counted, it throws an exception because it can no longer reliably compute the number of committed records during the sync. This error has caused some confusion recently (see https://github.com/airbytehq/oncall/issues/110 and #9629) because it currently reads like a severe error. In reality, this error only impacts the metadata that we summarize at the end of the sync, and does not indicate an issue with the sync data itself.
How
This PR changes the severity of the log from
errortowarning, and adds additional text to clarify that only sync metadata is impacted.