-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Source Recurly: avoid loading all accounts when importing account coupon redemptions #9382
Merged
marcosmarxm
merged 5 commits into
airbytehq:master
from
mohamagdy:avoid-loading-all-accounts-in-recurly-coupon-redemptions
Jan 10, 2022
Merged
🐛 Source Recurly: avoid loading all accounts when importing account coupon redemptions #9382
marcosmarxm
merged 5 commits into
airbytehq:master
from
mohamagdy:avoid-loading-all-accounts-in-recurly-coupon-redemptions
Jan 10, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mohamagdy
changed the title
Avoid loading all accounts when importing account coupon redemptions
🐛 Avoid loading all accounts when importing account coupon redemptions
Jan 10, 2022
Awesome @mohamagdy can you bump the connector version? See instructions here |
marcosmarxm
changed the title
🐛 Avoid loading all accounts when importing account coupon redemptions
🐛 Source Recurly: avoid loading all accounts when importing account coupon redemptions
Jan 10, 2022
mohamagdy
force-pushed
the
avoid-loading-all-accounts-in-recurly-coupon-redemptions
branch
from
January 10, 2022 16:54
aafd615
to
dcb645d
Compare
github-actions
bot
added
the
area/documentation
Improvements or additions to documentation
label
Jan 10, 2022
mohamagdy
force-pushed
the
avoid-loading-all-accounts-in-recurly-coupon-redemptions
branch
from
January 10, 2022 16:59
dcb645d
to
23a3fe7
Compare
github-actions
bot
added
area/platform
issues related to the platform
area/server
labels
Jan 10, 2022
@marcosmarxm thank you for taking a look. Bumped the version here 23a3fe7. |
marcosmarxm
approved these changes
Jan 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome @mohamagdy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/connectors
Connector related issues
area/documentation
Improvements or additions to documentation
area/platform
issues related to the platform
area/server
community
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Avoid loading all Recurly accounts when importing account code redemptions. Only import the accounts having coupon redemptions created.
How
Only import the accounts having coupon redemptions created by setting the
params
field when sending the request to Recurly API.Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/SUMMARY.md
docs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md