Google ads added fields and reports #9310
merge master
- Loading branch information
commit fe5e4bae9cd3c817467ddbc980dd5565ee4caee9
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,7 +24,12 @@ | |
| ClickView, | ||
| DisplayKeywordPerformanceReport, | ||
| DisplayTopicsPerformanceReport, | ||
| <<<<<<< HEAD | ||
| KeywordView, | ||
|
There was a problem hiding this comment. @schlattk stream |
||
| ======= | ||
| GeographicReport, | ||
| KeywordReport, | ||
| >>>>>>> master | ||
| ShoppingPerformanceReport, | ||
| UserLocationReport, | ||
| ) | ||
|
|
@@ -107,5 +112,31 @@ def streams(self, config: Mapping[str, Any]) -> List[Stream]: | |
| Accounts(api=google_api), | ||
| Campaigns(**incremental_stream_config), | ||
augan-rymkhan marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| ClickView(**incremental_stream_config), | ||
| <<<<<<< HEAD | ||
| KeywordView(**incremental_stream_config) | ||
|
There was a problem hiding this comment. No need in |
||
| ] + custom_query_streams | ||
| ======= | ||
| ] | ||
|
|
||
| custom_query_streams = [ | ||
| CustomQuery(custom_query_config=single_query_config, **incremental_stream_config) | ||
| for single_query_config in config.get("custom_queries", []) | ||
| ] | ||
| streams.extend(custom_query_streams) | ||
|
|
||
| # Metrics streams cannot be requested for a manager account. | ||
| if not self.is_manager_account(account_info): | ||
| streams.extend( | ||
| [ | ||
| UserLocationReport(**incremental_stream_config), | ||
| AccountPerformanceReport(**incremental_stream_config), | ||
| DisplayTopicsPerformanceReport(**incremental_stream_config), | ||
| DisplayKeywordPerformanceReport(**incremental_stream_config), | ||
| ShoppingPerformanceReport(**incremental_stream_config), | ||
| AdGroupAdReport(**incremental_stream_config), | ||
| GeographicReport(**incremental_stream_config), | ||
| KeywordReport(**incremental_stream_config), | ||
| ] | ||
| ) | ||
| return streams | ||
| >>>>>>> master | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -228,8 +228,4 @@ class ClickView(IncrementalGoogleAdsStream): | |
| """ | ||
|
|
||
| days_of_data_storage = 90 | ||
| range_days = 1 | ||
You are viewing a condensed version of this merge commit. You can view the full changes here.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@schlattk Error happens because this field was added.
message: "Cannot select the following segments because at least one unsupported metric is found in SELECT or WHERE clause: \'segments.ad_network_type\'(unsupported metrics: \'historical_quality_score\')."\n}\nrequest_id: "hBx3G90_bSZ-rVpnBMQlxQ"\n, 'hBx3G90_bSZ-rVpnBMQlxQ')"}}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works when
readcommand is run without this field.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@augan-rymkhan ok but it is a supported field according to documentation and also it has been running live for a long time without any errors. What do you suggest is the solution?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@schlattk It seems we can not query
metrics.historical_quality_scoreandsegments.ad_network_typetogether inkeyword_reportstream.In docs:
A segment in the SELECT clause is incompatible with a metric in the SELECT or WHERE clause.
For more you can read PROHIBITED_SEGMENT_WITH_METRIC_IN_SELECT_OR_WHERE_CLAUSE.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes @augan-rymkhan that appears to be the problem. Ok, I removed the field I think we can most probably do without it in this report.