Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fields in destination-connectors specifications: meilisearch #9156

Merged
merged 4 commits into from
Dec 29, 2021

Conversation

igrankova
Copy link
Contributor

What

Add title and description properties to each field in destination-connectors specifications:
destination-meilisearch

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

@igrankova igrankova self-assigned this Dec 28, 2021
@github-actions github-actions bot added the area/connectors Connector related issues label Dec 28, 2021
@igrankova igrankova temporarily deployed to more-secrets December 28, 2021 14:27 Inactive
@igrankova igrankova linked an issue Dec 28, 2021 that may be closed by this pull request
@igrankova igrankova temporarily deployed to more-secrets December 28, 2021 14:32 Inactive
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Dec 28, 2021
@igrankova
Copy link
Contributor Author

igrankova commented Dec 28, 2021

/test connector=connectors/destination-meilisearch

🕑 connectors/destination-meilisearch https://github.com/airbytehq/airbyte/actions/runs/1630820137
✅ connectors/destination-meilisearch https://github.com/airbytehq/airbyte/actions/runs/1630820137
No Python unittests run

@igrankova igrankova temporarily deployed to more-secrets December 28, 2021 14:34 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 28, 2021 14:35 Inactive
@annalvova05
Copy link
Contributor

annalvova05 commented Dec 29, 2021

/publish connector=connectors/destination-meilisearch

🕑 connectors/destination-meilisearch https://github.com/airbytehq/airbyte/actions/runs/1633814611
✅ connectors/destination-meilisearch https://github.com/airbytehq/airbyte/actions/runs/1633814611

@jrhizor jrhizor temporarily deployed to more-secrets December 29, 2021 11:22 Inactive
@annalvova05 annalvova05 merged commit 7ecc9ac into master Dec 29, 2021
@annalvova05 annalvova05 deleted the igrankova/issue-8949-update-title-description branch December 29, 2021 11:33
@annalvova05 annalvova05 temporarily deployed to more-secrets December 29, 2021 11:34 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Update fields in destination-connectors specifications: meilisearch
4 participants