Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix auto migration test #8970

Merged
merged 2 commits into from
Dec 20, 2021
Merged

fix auto migration test #8970

merged 2 commits into from
Dec 20, 2021

Conversation

cgardens
Copy link
Contributor

@cgardens cgardens commented Dec 20, 2021 •
edited
Loading

What

  • The automigration acceptance test has been failing since this commit.
  • It was failing because that commit bumped source-postgres to a new minor version which meant that one of the asserts about the connector version that the test was making didn't pass anymore. The test should be robust to this.

How

  • just made the constraint less strict for now. this is a short term fix, we should improve our version comparison for connector versions, just like we have for AirbyteVersion for the platform

@cgardens cgardens temporarily deployed to more-secrets December 20, 2021 20:45 Inactive
@cgardens cgardens temporarily deployed to more-secrets December 20, 2021 20:50 Inactive
@cgardens cgardens marked this pull request as ready for review December 20, 2021 20:51
@cgardens cgardens merged commit b920dc8 into master Dec 20, 2021
@cgardens cgardens deleted the cgardens/fix-auto-migration-test branch December 20, 2021 20:51
@jrhizor jrhizor mentioned this pull request Dec 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cgardens