Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong param typo. Add proper index check for connection #8968

Merged
merged 5 commits into from
Dec 20, 2021
Merged

Fix wrong param typo. Add proper index check for connection #8968

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
00b496c
Fix wrong param typo. Add proper index check for connection
jamakase Dec 20, 2021
fcf0e64
Remove redundant log
jamakase Dec 20, 2021
c44ab6f
Remove unnecessary space
jamakase Dec 20, 2021
d791ba1
Change it vice versa
jamakase Dec 20, 2021
d96723c
Redirect to connection page after it was created
jamakase Dec 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions airbyte-webapp/src/pages/ConnectionPage/pages/CreationFormPage/CreationFormPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,8 @@ function usePreloadData(): {
const CreationFormPage: React.FC<IProps> = ({}) => {
const { location, push } = useRouter();

const locationType = location.pathname.split("/")[2];
// TODO: Probably there is a better way to figure it out instead of just checking third elem
const locationType = location.pathname.split("/")[3];

const type =
locationType === "connections"
Expand Down Expand Up @@ -123,7 +124,7 @@ const CreationFormPage: React.FC<IProps> = ({}) => {
push("", {
state: {
...(location.state as Record<string, unknown>),
sourceId: id,
destinationId: id,
},
});
setCurrentEntityStep(EntityStepsTypes.DESTINATION);
Expand Down