-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 CDK: Fix the logging of unhandled exceptions to show stacktrace #8704
Conversation
|
/publish-cdk dry-run=false
|
…rbytehq#8704) * print stacktrace for unhandled exceptions Co-authored-by: Eugene Kulak <kulak.eugene@gmail.com>
What
After #8211 was merged all unhandled exceptions logs via logging as a critical error. We also need to stack trace as it was before.
How
add
exc_info=exception_value
tologger.critical
calladd tests to cover this case and prevent future breaks
Recommended reading order
logger.py
test_logger.py
🚨 User Impact 🚨
the output will include stacktrace now: