Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding unit tests to SAT full refresh test #8589

Merged
merged 10 commits into from
Dec 21, 2021
Merged

Adding unit tests to SAT full refresh test #8589

merged 10 commits into from
Dec 21, 2021

Conversation

eliziario
Copy link
Contributor

@eliziario eliziario commented Dec 7, 2021 •
edited
Loading

What

Will close #6433

How

Adding tests to test_full_refresh to further validate the functionality and improve coverage on this part of sat

Recommended reading order

  1. test_test_full_refresh.py

@eliziario eliziario temporarily deployed to more-secrets December 9, 2021 14:08 Inactive
@eliziario eliziario marked this pull request as ready for review December 9, 2021 14:08
@eliziario eliziario changed the title WIP - Adding unit tests to SAT full refresh test Adding unit tests to SAT full refresh test Dec 9, 2021
keu
keu approved these changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@keu keu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just one comment about symmetric diff

@eliziario @keu
Update airbyte-integrations/bases/source-acceptance-test/unit_tests/t…
f1ef6d2 
…est_test_full_refresh.py

Co-authored-by: Eugene Kulak <widowmakerreborn@gmail.com>
@eliziario eliziario temporarily deployed to more-secrets December 16, 2021 13:53 Inactive
@eliziario eliziario temporarily deployed to more-secrets December 21, 2021 13:48 Inactive
@eliziario
Copy link
Contributor Author

eliziario commented Dec 21, 2021 •
edited by github-actions bot
Loading

/publish-cdk dry-run=true

🕑 https://github.com/airbytehq/airbyte/actions/runs/1607080085
✅ https://github.com/airbytehq/airbyte/actions/runs/1607080085

@eliziario
Copy link
Contributor Author

eliziario commented Dec 21, 2021 •
edited by github-actions bot
Loading

/publish-cdk dry-run=false

🕑 https://github.com/airbytehq/airbyte/actions/runs/1607126329
❌ https://github.com/airbytehq/airbyte/actions/runs/1607126329

@github-actions github-actions bot added the CDK Connector Development Kit label Dec 21, 2021
@eliziario
Copy link
Contributor Author

eliziario commented Dec 21, 2021 •
edited by github-actions bot
Loading

/publish-cdk dry-run=true

🕑 https://github.com/airbytehq/airbyte/actions/runs/1607221876
✅ https://github.com/airbytehq/airbyte/actions/runs/1607221876

@eliziario eliziario temporarily deployed to more-secrets December 21, 2021 14:29 Inactive
@eliziario
Copy link
Contributor Author

eliziario commented Dec 21, 2021 •
edited by github-actions bot
Loading

/publish-cdk dry-run=false

🕑 https://github.com/airbytehq/airbyte/actions/runs/1607273885
❌ https://github.com/airbytehq/airbyte/actions/runs/1607273885

@eliziario
Copy link
Contributor Author

eliziario commented Dec 21, 2021 •
edited by github-actions bot
Loading

/publish-cdk dry-run=false

🕑 https://github.com/airbytehq/airbyte/actions/runs/1607319460
✅ https://github.com/airbytehq/airbyte/actions/runs/1607319460

@eliziario eliziario temporarily deployed to more-secrets December 21, 2021 14:54 Inactive
@eliziario eliziario merged commit fd716d7 into master Dec 21, 2021
@eliziario eliziario deleted the eliziario/6433_ignore_fields_on_sat branch December 21, 2021 15:09
@eliziario eliziario temporarily deployed to more-secrets December 21, 2021 15:10 Inactive
@jrhizor jrhizor mentioned this pull request Dec 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keu keu keu approved these changes

@sergei-solonitcyn sergei-solonitcyn Awaiting requested review from sergei-solonitcyn

@vitaliizazmic vitaliizazmic Awaiting requested review from vitaliizazmic

@augan-rymkhan augan-rymkhan Awaiting requested review from augan-rymkhan

Assignees
No one assigned
Labels
CDK Connector Development Kit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SAT: add option to ignore specific fields when checking expected records
2 participants
@eliziario @keu