Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flake8 fix 3764 obfuscate secrets logging #8583

Merged
merged 19 commits into from
Dec 7, 2021

Conversation

eliziario
Copy link
Contributor

fixes flake8 error on latest pull request/formatting

@github-actions github-actions bot added the CDK Connector Development Kit label Dec 7, 2021
@eliziario eliziario temporarily deployed to more-secrets December 7, 2021 14:04 Inactive
@eliziario eliziario requested a review from keu December 7, 2021 14:05
@eliziario
Copy link
Contributor Author

eliziario commented Dec 7, 2021

/publish-cdk --dry-run=false

Error: Unexpected inputs provided: ["--dry-run"]

@eliziario eliziario temporarily deployed to more-secrets December 7, 2021 14:06 Inactive
@eliziario
Copy link
Contributor Author

eliziario commented Dec 7, 2021

@eliziario
Copy link
Contributor Author

eliziario commented Dec 7, 2021

/publish-cdk dry-run=false

🕑 https://github.com/airbytehq/airbyte/actions/runs/1549824604
https://github.com/airbytehq/airbyte/actions/runs/1549824604

@eliziario eliziario temporarily deployed to more-secrets December 7, 2021 14:22 Inactive
@eliziario eliziario merged commit 34ff075 into master Dec 7, 2021
@eliziario eliziario deleted the eliziario/3764_obfuscate_secrets_logging branch December 7, 2021 14:35
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
* Secure logger implementation minus still broken new tests

* Secure logger implementation and unit tests

* code review changes

* filter text on uncaught exceptions

* auto-formatting

* Mistaken change left in code

* filter text on uncaught exceptions

* Simplify code, remove LoggingFilter and move obfuscation functionality to Formatter

* Update airbyte-cdk/python/airbyte_cdk/entrypoint.py

Co-authored-by: Eugene Kulak <widowmakerreborn@gmail.com>

* Obfuscate Secrets in Logging, code review changes

* Obfuscate Secrets in Logging, code review changes, unit test fixes

* CHANGELOG.md

* Format and flake8

* Fix build error/bump version/format

* Add airbyte prefix on test logger

Co-authored-by: Eugene Kulak <widowmakerreborn@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CDK Connector Development Kit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant