remove legacy migration code #8499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
lmossman
reviewed
Dec 3, 2021
Comment on lines
+6
to
7
| serialize = | ||
| {major}.{minor}.{patch}-alpha |
There was a problem hiding this comment.
nit: the formatting here is a little weird, would be nice if this was on a single line. Does the gradle formatter do this for some reason?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
In version 0.32.0 we stopped using the legacy migration system (#8121). We left the code in so that if we needed to revert it would not be over a massive surface area. Things are stable now and we know we will not revert so it is time to 🔪 the legacy migration system code.
Reading Order
It is worth reviewing anything that is NOT in the
airbyte-migrationdirectory. everything in that directory is just a straight deletion as it was its own gradle submodule.