CDK: Add base pydantic model for connector config and schemas #8485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
keu
force-pushed
the
keu/cdk-base-pydantic-models
branch
from
f2cfb49 to
0b7674e
Compare
16 tasks
keu
changed the title
keu
commented
Dec 7, 2021
| @@ -186,6 +185,7 @@ def _read_incremental( | |||
| for record_counter, record_data in enumerate(records, start=1): | |||
| yield self._as_airbyte_record(stream_name, record_data) | |||
| stream_state = stream_instance.get_updated_state(stream_state, record_data) | |||
| checkpoint_interval = stream_instance.state_checkpoint_interval | |||
There was a problem hiding this comment.
this fixes issue with dynamic behaviour of state_checkpoint_interval (may change after read call)
vitaliizazmic
approved these changes
Dec 7, 2021
|
/publish-cdk dry-run=false
|
schlattk
pushed a commit
to schlattk/airbyte
that referenced
this pull request
Jan 4, 2022
…ehq#8485) * add base spec model * fix usage of state_checkpoint_interval in case it is dynamic * add schema base models, fix spelling, signatures and polishing Co-authored-by: Eugene Kulak <kulak.eugene@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
When we use pydantic model instead of spec.json we often duplicate the same piece of logic every time. It would be nice to have some common base model provided by CDK that will:
How
Define
config.BaseConfigandsources.utils.schema_models.BaseSchemaModelclasses that can be used instead ofpydantic.BaseModelRecommended reading order
x.javay.python🚨 User Impact 🚨
Doesn't change existing behavior. Existing connectors need an update to start using the piece of code added in this PR.
Pre-merge Checklist
Expand the relevant checklist and delete the others.