-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Output run time per stream #8173
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avida
reviewed
Nov 22, 2021
airbyte-integrations/bases/base-python/base_python/cdk/abstract_source.py
Outdated
Show resolved
Hide resolved
avida
reviewed
Nov 22, 2021
airbyte-integrations/bases/base-python/base_python/cdk/utils/event_timing.py
Outdated
Show resolved
Hide resolved
keu
reviewed
Nov 22, 2021
airbyte-integrations/bases/base-python/base_python/cdk/utils/event_timing.py
Outdated
Show resolved
Hide resolved
keu
reviewed
Nov 22, 2021
airbyte-integrations/bases/base-python/base_python/cdk/utils/event_timing.py
Outdated
Show resolved
Hide resolved
Port code to cdk
avida
approved these changes
Nov 24, 2021
This was referenced Dec 1, 2021
schlattk
pushed a commit
to schlattk/airbyte
that referenced
this pull request
Jan 4, 2022
* Output run time per stream * Code review changes: Remove multithreaded support. Port code to cdk * Formatting * remove extraneous try block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes #7965
How
An EventTimer class is introduced along with a context manager. Due to the possibility that streams could be run in parallell in the future, care has been taken to ensure EventTimer is thread safe
Recommended reading order
abstract_source.py
event_timing.py
🚨 User Impact 🚨
Connectors need to rebuilt for change to be reflected
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/SUMMARY.md
docs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described hereUpdating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described hereConnector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changes