Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 CDK: Add logger inheritance for streams from airbyte #8040

Merged
merged 2 commits into from
Nov 17, 2021

Conversation

yevhenii-ldv
Copy link
Contributor

What

resolves #7981.

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? If yes, please make sure to include it here and in any changelogs with the 🚨🚨 emoji
What is the end result perceived by the user?

Pre-merge Checklist

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

@yevhenii-ldv yevhenii-ldv temporarily deployed to more-secrets November 17, 2021 08:33 Inactive
@github-actions github-actions bot added the CDK Connector Development Kit label Nov 17, 2021
@yevhenii-ldv
Copy link
Contributor Author

yevhenii-ldv commented Nov 17, 2021

/publish-cdk dry-run=false

🕑 https://github.com/airbytehq/airbyte/actions/runs/1470887946
https://github.com/airbytehq/airbyte/actions/runs/1470887946

@yevhenii-ldv yevhenii-ldv merged commit d64b113 into master Nov 17, 2021
@yevhenii-ldv yevhenii-ldv deleted the ykurochkin/cdk-broken-logger-in-streams branch November 17, 2021 09:37
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
)

* Fix broken logger in streams: add logger inheritance for streams from airbyte
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CDK Connector Development Kit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CDK: broken logger in streams
3 participants