Add temporal to docker compose build #7888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-temporal-to-compose-build
lmossman
reviewed
Nov 11, 2021
docker-compose.build.yaml
Outdated
| @@ -50,3 +50,10 @@ services: | |||
| context: airbyte-migration | |||
| labels: | |||
| io.airbyte.git-revision: ${GIT_REVISION} | |||
| airbyte-temporal: | |||
There was a problem hiding this comment.
should this be temporal instead of airbyte-temporal? I'm only basing this question off of the other entries in this file
There was a problem hiding this comment.
you're right, Done.
lmossman
reviewed
Nov 12, 2021
| @@ -50,3 +50,10 @@ services: | |||
| context: airbyte-migration | |||
| labels: | |||
| io.airbyte.git-revision: ${GIT_REVISION} | |||
| temporal: | |||
There was a problem hiding this comment.
Looks like you may need to add this to the -m1 compose build file as well? https://github.com/airbytehq/airbyte/blob/master/docker-compose.build-m1.yaml
There was a problem hiding this comment.
This file should be unused. I don't think it is needed for the push operation, it was just for the up which is now unused.
cgardens
approved these changes
Nov 12, 2021
schlattk
pushed a commit
to schlattk/airbyte
that referenced
this pull request
Jan 4, 2022
* Add temporal to docker compose build * Rm the airbyte prefix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Make the build to push all the artifact