Skip to content

Conversation

avida
Copy link
Contributor

@avida avida commented Nov 9, 2021

What

Resolves #7558

How

Split email send stream into slices with range of 90 days each.

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Nov 9, 2021
@avida avida temporarily deployed to more-secrets November 9, 2021 11:00 Inactive
@avida avida force-pushed the drezchykov/iterable-fix branch from 2b53ab5 to 8e17cf9 Compare November 9, 2021 11:00
@avida
Copy link
Contributor Author

avida commented Nov 9, 2021

/test connector=connectors/source-iterable

🕑 connectors/source-iterable https://github.com/airbytehq/airbyte/actions/runs/1439135310
❌ connectors/source-iterable https://github.com/airbytehq/airbyte/actions/runs/1439135310
🐛 https://gradle.com/s/qtmnmfxw26mxy

@avida avida temporarily deployed to more-secrets November 9, 2021 11:02 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 9, 2021 11:03 Inactive
@avida avida force-pushed the drezchykov/iterable-fix branch from 8e17cf9 to 38f4750 Compare November 9, 2021 11:23
@avida
Copy link
Contributor Author

avida commented Nov 9, 2021

/test connector=connectors/source-iterable

🕑 connectors/source-iterable https://github.com/airbytehq/airbyte/actions/runs/1439219354
✅ connectors/source-iterable https://github.com/airbytehq/airbyte/actions/runs/1439219354
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        75      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              200     94    53%
	 source_acceptance_test/tests/test_full_refresh.py       38     27    29%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     24    41%
	 source_acceptance_test/utils/compare.py                 62     25    60%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  896    440    51%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                  Stmts   Miss  Cover
	 ---------------------------------------------------------
	 source_iterable/__init__.py               2      0   100%
	 source_iterable/api.py                  159     69    57%
	 source_iterable/iterable_streams.py      99     15    85%
	 source_iterable/source.py                15      6    60%
	 ---------------------------------------------------------
	 TOTAL                                   275     90    67%

@avida avida temporarily deployed to more-secrets November 9, 2021 11:25 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 9, 2021 11:25 Inactive
@avida avida temporarily deployed to more-secrets November 9, 2021 11:29 Inactive
@avida avida force-pushed the drezchykov/iterable-fix branch from 7fcfdcb to 38fb76e Compare November 10, 2021 08:27
@avida avida temporarily deployed to more-secrets November 10, 2021 08:29 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 10, 2021 08:36 Inactive
@avida
Copy link
Contributor Author

avida commented Nov 10, 2021

/publish connector=connectors/source-iterable

🕑 connectors/source-iterable https://github.com/airbytehq/airbyte/actions/runs/1443376925
✅ connectors/source-iterable https://github.com/airbytehq/airbyte/actions/runs/1443376925

@jrhizor jrhizor temporarily deployed to more-secrets November 10, 2021 09:06 Inactive
@avida avida merged commit 6f70b6b into master Nov 10, 2021
@avida avida deleted the drezchykov/iterable-fix branch November 10, 2021 09:43
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Iterable Sync timeout/cancelation due to Memory Error/Heartbeat Failure
4 participants