Skip to content

Conversation

@devin-ai-integration
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Nov 28, 2025

What

Fixes the pagination parameter name in the Facebook Pages connector. The connector was using page_size as the query parameter name, but the Facebook Graph API expects limit. This caused the API to ignore the configured page size (100) and use its default value (25) instead.

This follow-up was identified during the review of community PR #66536 and maintainer PR #69714.

How

Changed the field_name in page_size_option from "page_size" to "limit" in the manifest.yaml.

Review guide

  1. airbyte-integrations/connectors/source-facebook-pages/source_facebook_pages/manifest.yaml - Single line change to pagination parameter name
  2. airbyte-integrations/connectors/source-facebook-pages/metadata.yaml - Version bump to 2.0.3
  3. airbyte-integrations/connectors/source-facebook-pages/pyproject.toml - Version bump to 2.0.3
  4. docs/integrations/sources/facebook-pages.md - Changelog entry for 2.0.3

Human review checklist

  • Verify Facebook Graph API uses limit as the pagination parameter (see Graph API docs)
  • Confirm version 2.0.3 is consistent across metadata.yaml and pyproject.toml

User Impact

Users will now get 100 records per page (as configured) instead of the API default of 25. This should improve sync performance by reducing the number of API calls needed.

Can this PR be safely reverted and rolled back?

  • YES 💚

Updates since last revision


Requested by: kat@airbyte.io

Link to Devin run: https://app.devin.ai/sessions/67fef610db054757bce07fb6cfcb3e92

Co-Authored-By: kat@airbyte.io <kat@airbyte.io>
@devin-ai-integration
Copy link
Contributor Author

Original prompt from kat@airbyte.io
Received message in Slack channel #ask-devin-ai:

@Devin could you tell me if the changes from this community pr <https://github.com/airbytehq/airbyte/pull/66536> are reflected in this airbyte maintainer pr: <https://github.com/airbytehq/airbyte/pull/69714>
Thread URL: https://airbytehq-team.slack.com/archives/C08BHPUMEPJ/p1764264984093839

@devin-ai-integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@github-actions
Copy link
Contributor

👋 Greetings, Airbyte Team Member!

Here are some helpful tips and reminders for your convenience.

Helpful Resources

PR Slash Commands

Airbyte Maintainers (that's you!) can execute the following slash commands on your PR:

  • /format-fix - Fixes most formatting issues.
  • /bump-version - Bumps connector versions.
    • You can specify a custom changelog by passing changelog. Example: /bump-version changelog="My cool update"
    • Leaving the changelog arg blank will auto-populate the changelog from the PR title.
  • /run-cat-tests - Runs legacy CAT tests (Connector Acceptance Tests)
  • /run-live-tests - Runs live tests for the modified connector(s).
  • /run-regression-tests - Runs regression tests for the modified connector(s).
  • /build-connector-images - Builds and publishes a pre-release docker image for the modified connector(s).
  • /publish-connectors-prerelease - Publishes pre-release connector builds (tagged as {version}-dev.{git-sha}) for all modified connectors in the PR.
  • JVM connectors:
    • /update-connector-cdk-version connector=<CONNECTOR_NAME> - Updates the specified connector to the latest CDK version.
      Example: /update-connector-cdk-version connector=destination-bigquery
    • /bump-bulk-cdk-version bump=patch changelog='foo' - Bump the Bulk CDK's version. bump can be major/minor/patch.
  • Python connectors:
    • /poe connector source-example lock - Run the Poe lock task on the source-example connector, committing the results back to the branch.
    • /poe source example lock - Alias for /poe connector source-example lock.
    • /poe source example use-cdk-branch my/branch - Pin the source-example CDK reference to the branch name specified.
    • /poe source example use-cdk-latest - Update the source-example CDK dependency to the latest available version.

📝 Edit this welcome message.

@devin-ai-integration
Copy link
Contributor Author

/bump-version

(Requested by kat@airbyte.io via Devin)

@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2025

source-facebook-pages Connector Test Results

12 tests   9 ✅  49s ⏱️
 2 suites  3 💤
 2 files    0 ❌

Results for commit 56a1218.

♻️ This comment has been updated with latest results.

@katmarkham
Copy link
Contributor

katmarkham commented Nov 28, 2025

/bump-version

Bump Version job started... Check job output.

🔴 Job completed successfully (no changes, this is sus).

Co-Authored-By: kat@airbyte.io <kat@airbyte.io>
@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2025

Deploy preview for airbyte-docs ready!

✅ Preview
https://airbyte-docs-az0jygcs5-airbyte-growth.vercel.app

Built with commit 56a1218.
This pull request is being automatically deployed with vercel-action

Co-Authored-By: kat@airbyte.io <kat@airbyte.io>
@darynaishchenko darynaishchenko merged commit 23a9ac6 into master Dec 1, 2025
37 of 38 checks passed
@darynaishchenko darynaishchenko deleted the devin/1764333982-fix-facebook-pages-pagination branch December 1, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants