-
Notifications
You must be signed in to change notification settings - Fork 4.9k
fix(source-facebook-pages): use correct pagination parameter name #70248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(source-facebook-pages): use correct pagination parameter name #70248
Conversation
Co-Authored-By: kat@airbyte.io <kat@airbyte.io>
Original prompt from kat@airbyte.io |
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. Helpful Resources
PR Slash CommandsAirbyte Maintainers (that's you!) can execute the following slash commands on your PR:
|
|
/bump-version (Requested by kat@airbyte.io via Devin) |
|
|
/bump-version
|
Co-Authored-By: kat@airbyte.io <kat@airbyte.io>
|
Deploy preview for airbyte-docs ready! ✅ Preview Built with commit 56a1218. |
Co-Authored-By: kat@airbyte.io <kat@airbyte.io>
What
Fixes the pagination parameter name in the Facebook Pages connector. The connector was using
page_sizeas the query parameter name, but the Facebook Graph API expectslimit. This caused the API to ignore the configured page size (100) and use its default value (25) instead.This follow-up was identified during the review of community PR #66536 and maintainer PR #69714.
How
Changed the
field_nameinpage_size_optionfrom"page_size"to"limit"in the manifest.yaml.Review guide
airbyte-integrations/connectors/source-facebook-pages/source_facebook_pages/manifest.yaml- Single line change to pagination parameter nameairbyte-integrations/connectors/source-facebook-pages/metadata.yaml- Version bump to 2.0.3airbyte-integrations/connectors/source-facebook-pages/pyproject.toml- Version bump to 2.0.3docs/integrations/sources/facebook-pages.md- Changelog entry for 2.0.3Human review checklist
limitas the pagination parameter (see Graph API docs)User Impact
Users will now get 100 records per page (as configured) instead of the API default of 25. This should improve sync performance by reducing the number of API calls needed.
Can this PR be safely reverted and rolled back?
Updates since last revision
Requested by: kat@airbyte.io
Link to Devin run: https://app.devin.ai/sessions/67fef610db054757bce07fb6cfcb3e92