Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎉 Source Google Analytics v4: add intermediary auth config support #7020

Merged
merged 3 commits into from
Oct 14, 2021
Merged

🎉 Source Google Analytics v4: add intermediary auth config support #7020

merged 3 commits into from
Oct 14, 2021

Conversation

gaart
Copy link
Contributor

@gaart gaart commented Oct 13, 2021 •
edited
Loading

What

Closes #6977

How

Add intermediary auth config support

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

@github-actions github-actions bot added the area/connectors Connector related issues label Oct 13, 2021
@gaart gaart temporarily deployed to more-secrets October 13, 2021 20:06 Inactive
@gaart
Copy link
Contributor Author

gaart commented Oct 13, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-google-analytics-v4

🕑 connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1339076234
✅ connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1339076234
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              200     94    53%
	 source_acceptance_test/tests/test_full_refresh.py       18     11    39%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     24    41%
	 source_acceptance_test/utils/compare.py                 47     20    57%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  860    419    51%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                     Stmts   Miss  Cover
	 ------------------------------------------------------------
	 source_google_analytics_v4/__init__.py       2      0   100%
	 source_google_analytics_v4/source.py       224    107    52%
	 ------------------------------------------------------------
	 TOTAL                                      226    107    53%

@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Oct 13, 2021
@gaart gaart changed the title Add intermediary auth config support 🎉 Source Google Analytics v4: add intermediary auth config support Oct 13, 2021
@gaart gaart temporarily deployed to more-secrets October 13, 2021 20:08 Inactive
keu
keu reviewed Oct 13, 2021
View reviewed changes
airbyte-integrations/connectors/source-google-analytics-v4/source_google_analytics_v4/spec.json
@@ -79,7 +78,7 @@
{
"type": "object",
"title": "Service Account Key Authentication",
"required": ["auth_type", "credentials_json"],
"required": ["credentials_json"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't credentials_json have airbyte_secret=true ?

keu
keu suggested changes Oct 13, 2021
View reviewed changes
Copy link
Contributor

@keu keu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question

@sherifnada
Copy link
Contributor

LGTM if you address keu's comment

@gaart gaart requested a review from keu October 14, 2021 13:13
@gaart gaart temporarily deployed to more-secrets October 14, 2021 13:14 Inactive
@gaart
Copy link
Contributor Author

gaart commented Oct 14, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-google-analytics-v4

🕑 connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1342029843
✅ connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1342029843
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              200     94    53%
	 source_acceptance_test/tests/test_full_refresh.py       18     11    39%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     24    41%
	 source_acceptance_test/utils/compare.py                 47     20    57%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  860    419    51%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                     Stmts   Miss  Cover
	 ------------------------------------------------------------
	 source_google_analytics_v4/__init__.py       2      0   100%
	 source_google_analytics_v4/source.py       224    107    52%
	 ------------------------------------------------------------
	 TOTAL                                      226    107    53%

@jrhizor jrhizor temporarily deployed to more-secrets October 14, 2021 13:40 Inactive
@gaart
Copy link
Contributor Author

gaart commented Oct 14, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-google-analytics-v4

🕑 connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1342064639
✅ connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1342064639

@jrhizor jrhizor temporarily deployed to more-secrets October 14, 2021 13:49 Inactive
@gaart gaart merged commit 62826f8 into master Oct 14, 2021
@gaart gaart deleted the gaart/5634-google-analytics-oauth branch October 14, 2021 14:00
@jrhizor jrhizor mentioned this pull request Oct 19, 2021
Merged
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
@gaart @schlattk
🎉 Source Google Analytics v4: add intermediary auth config support (a…
075171e 
…irbytehq#7020)

* Add intermediary auth config support

* Upd changelog

* Mark spec param as secret
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherifnada sherifnada sherifnada approved these changes

@eliziario eliziario Awaiting requested review from eliziario

@vitaliizazmic vitaliizazmic Awaiting requested review from vitaliizazmic

@keu keu Awaiting requested review from keu

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SRC Google Analytics V4] Syncs on 0.1.7 fails when upgrading from 0.1.6
4 participants
@gaart @sherifnada @keu @jrhizor