-
Couldn't load subscription status.
- Fork 4.9k
Jose/add dedup #68654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature/destination-postgres
Are you sure you want to change the base?
Jose/add dedup #68654
Conversation
π Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. Helpful Resources
PR Slash CommandsAirbyte Maintainers (that's you!) can execute the following slash commands on your PR:
|
|
| val columnDeclarations = columnsAndTypes(stream, columnNameMapping).joinToString(",\n") | ||
| val columnDeclarations = columnsAndTypes(stream, columnNameMapping).joinToString(",\n") {it.toSQLString() } | ||
| val dropTableIfExistsStatement = if (replace) "DROP TABLE IF EXISTS ${getFullyQualifiedName(tableName)};" else "" | ||
| val createIndexesStatement = createIndexes(stream, tableName, columnNameMapping) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm creating indexes for both primary keys and cursor. What should happen if the user changes the primary keys and/or cursor? Should we recreate the indexes in ensureSchemaMatches? I'm not sure if that's the expectation since this might be an expensive operation.
Lines 3163 to 3173 in 7b979b6
| /** | |
| * This is a bit of an edge case, but we should handle it regardless. If the user configures a | |
| * primary key, then changes it (e.g. they realize that their composite key doesn't need to | |
| * include a certain column), we should do _something_ reasonable. | |
| * | |
| * Intentionally not doing a complex scenario here; users should probably just truncate refresh | |
| * if they want to do this. Just assert that if we upsert a record after changing the PK, the | |
| * upsert looks correct. | |
| */ | |
| @Test | |
| open fun testDedupChangePk() { |
this comment makes me think that we don't 100% support this
What
How
Review guide
User Impact
Can this PR be safely reverted and rolled back?