Skip to content

docs: Remove future promise from Java destinations update #68650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

docs: Remove future promise from Java destinations update #68650

wants to merge 7 commits into from

Conversation

@ian-at-airbyte
Copy link
Contributor

@ian-at-airbyte ian-at-airbyte commented Oct 24, 2025 •
edited
Loading

What

  • Remove future promise from contribution documentation. Aside from missing this deadline, we should not, as a matter of policy, make future promises in documentation.
  • Updated get-modified-connectors.sh to stop ignoring files called "README.md" that are outside connector folders. If a change contained only docs files called README.md, CI fails. This prevented this change from ever passing CI, because all files were called README.md.

How

Review guide

User Impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

ian-at-airbyte and others added 7 commits October 24, 2025 14:30
@ian-at-airbyte
Remove future promise.
f8b94a1
@ian-at-airbyte
Revert "Remove future promise."
fc668ee 
This reverts commit f8b94a1.
@ian-at-airbyte
Try without modifying historical versions
9cf2a29
@ian-at-airbyte
Revert "Try without modifying historical versions"
a0aa350 
This reverts commit 9cf2a29.
@ian-at-airbyte
Try it this way
4a9aecf
@ian-at-airbyte
Reapply "Remove future promise."
33981a8 
This reverts commit fc668ee.
@devin-ai-integration @ian-at-airbyte
fix: make connector ignore patterns more specific to avoid filtering …
bacfb25 
…docs (#68649)

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: ian.alton@airbyte.io <ian.alton@airbyte.io>
@github-actions
Copy link
Contributor

👋 Greetings, Airbyte Team Member!

Here are some helpful tips and reminders for your convenience.

Helpful Resources

PR Slash Commands

Airbyte Maintainers (that's you!) can execute the following slash commands on your PR:

  • /format-fix - Fixes most formatting issues.
  • /bump-version - Bumps connector versions.
    • You can specify a custom changelog by passing changelog. Example: /bump-version changelog="My cool update"
    • Leaving the changelog arg blank will auto-populate the changelog from the PR title.
  • /run-cat-tests - Runs legacy CAT tests (Connector Acceptance Tests)
  • /build-connector-images - Builds and publishes a pre-release docker image for the modified connector(s).
  • JVM connectors:
    • /update-connector-cdk-version connector=<CONNECTOR_NAME> - Updates the specified connector to the latest CDK version.
      Example: /update-connector-cdk-version connector=destination-bigquery
    • /bump-bulk-cdk-version type=patch changelog='foo' - Bump the Bulk CDK's version. type can be major/minor/patch.
  • Python connectors:
    • /poe connector source-example lock - Run the Poe lock task on the source-example connector, committing the results back to the branch.
    • /poe source example lock - Alias for /poe connector source-example lock.
    • /poe source example use-cdk-branch my/branch - Pin the source-example CDK reference to the branch name specified.
    • /poe source example use-cdk-latest - Update the source-example CDK dependency to the latest available version.

📝 Edit this welcome message.

github-actions[bot]
github-actions bot reviewed Oct 24, 2025
View reviewed changes
@ian-at-airbyte ian-at-airbyte changed the title Docs java destinations update docs: Remove future promise from Java destinations update Oct 24, 2025
@github-actions
Copy link
Contributor

Deploy preview for airbyte-docs ready!

✅ Preview
https://airbyte-docs-3hnbhedx4-airbyte-growth.vercel.app

Built with commit bacfb25.
This pull request is being automatically deployed with vercel-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@aaronsteers aaronsteers Awaiting requested review from aaronsteers

@katmarkham katmarkham Awaiting requested review from katmarkham

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ian-at-airbyte